Skip to content

Add metadata information in tag on PD #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidz627 opened this issue Sep 18, 2019 · 13 comments · Fixed by #570
Closed

Add metadata information in tag on PD #387

davidz627 opened this issue Sep 18, 2019 · 13 comments · Fixed by #570
Assignees
Milestone

Comments

@davidz627
Copy link
Contributor

info like namespace and pvc name (check with feature parity for in-tree plugin)

@davidz627 davidz627 added this to the GA milestone Sep 18, 2019
@davidz627
Copy link
Contributor Author

In-tree plugin provisions with Description field example:

Description
{"kubernetes.io/created-for/pv/name":"pvc-6a10b78e-4cae-4c9e-8dd2-1cb2c60211e1","kubernetes.io/created-for/pvc/name":"test-disk","kubernetes.io/created-for/pvc/namespace":"default"}

No such thing as a "tag" AFAIK. Do people really rely on json description text? I guess we should continue this for backwards compatibility reasons. Considering adding some more description fields to specify the driver name that provisioned to volume.

/cc @msau42

@msau42
Copy link
Contributor

msau42 commented Oct 16, 2019

@davidz627
Copy link
Contributor Author

davidz627 commented Oct 16, 2019

IIRK labels are new and basically what we were trying to approximate with the description field before. Labels are not used by in-tree currently. They are empty on my test PD.

IIUC description should stay the same because of backwards compatibility (who is actually depending on this functionality...?). Do we even have any expectations for backwards compatibility for a freeform text field meant for human-readable descriptions?

We could duplicate whats in the description into the labels but that's almost uglier than only having them in the description. However, I would strongly prefer putting this information only in the labels and break the descriptions field.

@msau42
Copy link
Contributor

msau42 commented Oct 16, 2019

It has the possibility to break users once migration is on though.

@davidz627
Copy link
Contributor Author

Depends on: kubernetes-csi/external-provisioner#370

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2020
@davidz627
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2020
@davidz627
Copy link
Contributor Author

depends on: kubernetes-csi/external-provisioner#399

@verult
Copy link
Contributor

verult commented Apr 8, 2020

kubernetes-csi/external-provisioner#399 now available in v1.6.0

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2020
@verult
Copy link
Contributor

verult commented Jul 7, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2020
@shay-berman
Copy link

what is the status of this ticket?
I would like to know when CSI driver will be GA in GKE?

@saad-ali
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants