-
Notifications
You must be signed in to change notification settings - Fork 159
Add metadata information in tag on PD #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In-tree plugin provisions with
No such thing as a "tag" AFAIK. Do people really rely on json description text? I guess we should continue this for backwards compatibility reasons. Considering adding some more description fields to specify the driver name that provisioned to volume. /cc @msau42 |
What about "labels"? https://cloud.google.com/kubernetes-engine/docs/how-to/creating-managing-labels |
IIRK labels are new and basically what we were trying to approximate with the description field before. Labels are not used by in-tree currently. They are empty on my test PD. IIUC description should stay the same because of backwards compatibility (who is actually depending on this functionality...?). Do we even have any expectations for backwards compatibility for a freeform text field meant for human-readable descriptions? We could duplicate whats in the description into the labels but that's almost uglier than only having them in the description. However, I would strongly prefer putting this information only in the labels and break the descriptions field. |
It has the possibility to break users once migration is on though. |
Depends on: kubernetes-csi/external-provisioner#370 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
depends on: kubernetes-csi/external-provisioner#399 |
kubernetes-csi/external-provisioner#399 now available in v1.6.0 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
what is the status of this ticket? |
/assign |
info like namespace and pvc name (check with feature parity for in-tree plugin)
The text was updated successfully, but these errors were encountered: