Skip to content

Response parsing for projects ending in "v1", "beta" or "alpha" causes image lookup to fail #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pwschuurman opened this issue Dec 14, 2023 · 1 comment · Fixed by #1544

Comments

@pwschuurman
Copy link
Contributor

pwschuurman commented Dec 14, 2023

We have a function to "clean" a link fetched from the GCE API. This is typically a fully qualified link like the following:

https://www.googleapis.com/compute/v1/projects/k8s-jkns-gci-gce-alpha/global/images/gcepd-csi-e2e-f608826a-5761-4730-ba31-fabbc5c2ef08

The regex is not strict enough to segment based on "/" boundaries, so if the project ends in alpha (in this example), it will lead to the "clean" functionality to truncate the "projects/" segment, resulting in a parse error later.

See this gist for an example e2e test failure output: https://gist.github.com/pwschuurman/b5030e08538828514fe9c045a28df3e8. The following is a link to a prow test failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_gcp-compute-persistent-disk-csi-driver/1542/pull-gcp-compute-persistent-disk-csi-driver-e2e/1735154233054859264

@pwschuurman
Copy link
Contributor Author

We've seen this type of bug before in #1302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant