Skip to content

Validate the driver successfully came up in k8s test #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msau42 opened this issue Oct 26, 2018 · 7 comments
Open

Validate the driver successfully came up in k8s test #139

msau42 opened this issue Oct 26, 2018 · 7 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@msau42
Copy link
Contributor

msau42 commented Oct 26, 2018

Need to deal with the master DaemonSet pod pending

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@msau42
Copy link
Contributor Author

msau42 commented Apr 26, 2019

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2019
@davidz627 davidz627 added this to the Post-GA milestone Sep 18, 2019
@msau42
Copy link
Contributor Author

msau42 commented Jul 15, 2020

kubernetes/kubernetes#93120 may help validate the driver is registered successfully on all nodes.

It would be nice to also have a check that the controller deployment came up successfully

@mattcary
Copy link
Contributor

Is that a matter of polling for objects defined in the appropriate configs in cluster/addons?

@msau42
Copy link
Contributor Author

msau42 commented Jul 15, 2020

Yes, namely the Deployment in the gce-pd-csi-driver namespace.

@mattcary
Copy link
Contributor

/assign

Ok I'll take this.

@mattcary
Copy link
Contributor

Actually, the k/k change will not improve the k8s-integration test in this repo as it deploys the driver from a shell script.

I have a PR at https://github.com/mattcary/gcp-compute-persistent-disk-csi-driver/tree/wait (currently stacked up behind #610) that will fix the change in this repo too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants