Skip to content

Commit e200144

Browse files
sunnylovestiramisuk8s-infra-cherrypick-robot
authored and
k8s-infra-cherrypick-robot
committed
Revert "added labels for namespace and pvc names for a pv"
This reverts commit b271302.
1 parent 26460e7 commit e200144

File tree

2 files changed

+6
-26
lines changed

2 files changed

+6
-26
lines changed

pkg/common/parameters.go

+6-14
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,6 @@ const (
5858
tagKeyCreatedForSnapshotName = "kubernetes.io/created-for/volumesnapshot/name"
5959
tagKeyCreatedForSnapshotNamespace = "kubernetes.io/created-for/volumesnapshot/namespace"
6060
tagKeyCreatedForSnapshotContentName = "kubernetes.io/created-for/volumesnapshotcontent/name"
61-
62-
// Keys for labels to tag to PV
63-
labelKeyCreatedForClaimNamespace = "kubernetes_io_created-for_pvc_namespace"
64-
labelKeyCreatedForClaimName = "kubernetes_io_created-for_pvc_name"
65-
labelKeyCreatedForVolumeName = "kubernetes_io_created-for_pv_name"
6661
)
6762

6863
// DiskParameters contains normalized and defaulted disk parameters
@@ -133,15 +128,12 @@ func ExtractAndDefaultParameters(parameters map[string]string, driverName string
133128
case ParameterKeyDiskEncryptionKmsKey:
134129
// Resource names (e.g. "keyRings", "cryptoKeys", etc.) are case sensitive, so do not change case
135130
p.DiskEncryptionKMSKey = v
136-
case ParameterKeyPVCName:
137-
p.Tags[tagKeyCreatedForClaimName] = v
138-
p.Labels[labelKeyCreatedForClaimName] = v
139-
case ParameterKeyPVCNamespace:
140-
p.Tags[tagKeyCreatedForClaimNamespace] = v
141-
p.Labels[labelKeyCreatedForClaimNamespace] = v
142-
case ParameterKeyPVName:
143-
p.Tags[tagKeyCreatedForVolumeName] = v
144-
p.Labels[labelKeyCreatedForVolumeName] = v
131+
case ParameterKeyPVCName:
132+
p.Tags[tagKeyCreatedForClaimName] = v
133+
case ParameterKeyPVCNamespace:
134+
p.Tags[tagKeyCreatedForClaimNamespace] = v
135+
case ParameterKeyPVName:
136+
p.Tags[tagKeyCreatedForVolumeName] = v
145137
case ParameterKeyLabels:
146138
paramLabels, err := ConvertLabelsStringToMap(v)
147139
if err != nil {

pkg/common/parameters_test.go

-12
Original file line numberDiff line numberDiff line change
@@ -178,18 +178,6 @@ func TestExtractAndDefaultParameters(t *testing.T) {
178178
Labels: map[string]string{"key1": "value1", "label-1": "value-a", "label-2": "label-value-2"},
179179
},
180180
},
181-
{
182-
name: "PVC labels",
183-
parameters: map[string]string{ParameterKeyPVCName: "testPVCName", ParameterKeyPVCNamespace: "testPVCNamespace", ParameterKeyPVName: "testPVName"},
184-
labels: map[string]string{},
185-
expectParams: DiskParameters{
186-
DiskType: "pd-standard",
187-
ReplicationType: "none",
188-
DiskEncryptionKMSKey: "",
189-
Tags: map[string]string{},
190-
Labels: map[string]string{labelKeyCreatedForClaimName: "testPVCName", labelKeyCreatedForClaimNamespace: "testPVCNamespace", labelKeyCreatedForVolumeName: "testPVName"},
191-
},
192-
},
193181
}
194182

195183
for _, tc := range tests {

0 commit comments

Comments
 (0)