Skip to content

Commit c949b4f

Browse files
authored
Merge pull request #601 from jeremyje/versionflag
Rename vendorVersion to version to comply with build.make.
2 parents cb35ca8 + 82b70cd commit c949b4f

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ DOCKER=DOCKER_CLI_EXPERIMENTAL=enabled docker
2929
all: gce-pd-driver gce-pd-driver-windows
3030
gce-pd-driver:
3131
mkdir -p bin
32-
go build -mod=vendor -ldflags "-X main.vendorVersion=${STAGINGVERSION}" -o bin/${DRIVERBINARY} ./cmd/gce-pd-csi-driver/
32+
go build -mod=vendor -ldflags "-X main.version=${STAGINGVERSION}" -o bin/${DRIVERBINARY} ./cmd/gce-pd-csi-driver/
3333

3434
gce-pd-driver-windows:
3535
mkdir -p bin
36-
GOOS=windows go build -mod=vendor -ldflags -X=main.vendorVersion=$(STAGINGVERSION) -o bin/${DRIVERWINDOWSBINARY} ./cmd/gce-pd-csi-driver/
36+
GOOS=windows go build -mod=vendor -ldflags -X=main.version=$(STAGINGVERSION) -o bin/${DRIVERWINDOWSBINARY} ./cmd/gce-pd-csi-driver/
3737

3838
build-container: require-GCE_PD_CSI_STAGING_IMAGE
3939
$(DOCKER) build --build-arg TAG=$(STAGINGVERSION) -t $(STAGINGIMAGE):$(STAGINGVERSION) .

cmd/gce-pd-csi-driver/main.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ var (
3535
endpoint = flag.String("endpoint", "unix:/tmp/csi.sock", "CSI endpoint")
3636
runControllerService = flag.Bool("run-controller-service", true, "If set to false then the CSI driver does not activate its controller service (default: true)")
3737
runNodeService = flag.Bool("run-node-service", true, "If set to false then the CSI driver does not activate its node service (default: true)")
38-
vendorVersion string
38+
version string
3939
)
4040

4141
const (
@@ -62,10 +62,10 @@ func main() {
6262
func handle() {
6363
var err error
6464

65-
if vendorVersion == "" {
66-
klog.Fatalf("vendorVersion must be set at compile time")
65+
if version == "" {
66+
klog.Fatalf("version must be set at compile time")
6767
}
68-
klog.V(2).Infof("Driver vendor version %v", vendorVersion)
68+
klog.V(2).Infof("Driver vendor version %v", version)
6969

7070
gceDriver := driver.GetGCEDriver()
7171

@@ -79,7 +79,7 @@ func handle() {
7979
//Initialize requirements for the controller service
8080
var controllerServer *driver.GCEControllerServer
8181
if *runControllerService {
82-
cloudProvider, err := gce.CreateCloudProvider(ctx, vendorVersion, *cloudConfigFilePath)
82+
cloudProvider, err := gce.CreateCloudProvider(ctx, version, *cloudConfigFilePath)
8383
if err != nil {
8484
klog.Fatalf("Failed to get cloud provider: %v", err)
8585
}
@@ -104,7 +104,7 @@ func handle() {
104104
nodeServer = driver.NewNodeServer(gceDriver, mounter, deviceUtils, meta, statter)
105105
}
106106

107-
err = gceDriver.SetupGCEDriver(driverName, vendorVersion, identityServer, controllerServer, nodeServer)
107+
err = gceDriver.SetupGCEDriver(driverName, version, identityServer, controllerServer, nodeServer)
108108
if err != nil {
109109
klog.Fatalf("Failed to initialize GCE CSI Driver: %v", err)
110110
}

0 commit comments

Comments
 (0)