Skip to content

Commit c85f509

Browse files
committed
Added fixes for test key handling.
1 parent 5789a07 commit c85f509

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

pkg/common/parameters.go

+7-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ import (
2222
)
2323

2424
const (
25+
// Disk Params
26+
ParameterAccessMode = "access-mode"
27+
2528
// Parameters for StorageClass
2629
ParameterKeyType = "type"
2730
ParameterKeyReplicationType = "replication-type"
@@ -151,7 +154,6 @@ func (pp *ParameterProcessor) ExtractAndDefaultParameters(parameters map[string]
151154
Tags: make(map[string]string), // Default
152155
Labels: make(map[string]string), // Default
153156
ResourceTags: make(map[string]string), // Default
154-
AccessMode: "READ_WRITE_SINGLE", // Default
155157
}
156158

157159
for k, v := range extraVolumeLabels {
@@ -254,6 +256,10 @@ func (pp *ParameterProcessor) ExtractAndDefaultParameters(parameters map[string]
254256
if paramEnableMultiZoneProvisioning {
255257
p.Labels[MultiZoneLabel] = "true"
256258
}
259+
case ParameterAccessMode:
260+
if v != "" {
261+
p.AccessMode = v
262+
}
257263
default:
258264
return p, fmt.Errorf("parameters contains invalid option %q", k)
259265
}

test/e2e/tests/single_zone_e2e_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -1708,7 +1708,8 @@ func deleteVolumeOrError(client *remote.CsiClient, volID string) {
17081708
func createAndValidateUniqueZonalMultiWriterDisk(client *remote.CsiClient, project, zone string, diskType string) (string, string) {
17091709
// Create Disk
17101710
disk := typeToDisk[diskType]
1711-
disk.params.AccessMode = "READ_WRITE_MANY"
1711+
1712+
disk.params[common.ParameterAccessMode] = "READ_WRITE_MANY"
17121713

17131714
volName := testNamePrefix + string(uuid.NewUUID())
17141715
volume, err := client.CreateVolumeWithCaps(volName, disk.params, defaultMwSizeGb,

0 commit comments

Comments
 (0)