Skip to content

Commit c766b1f

Browse files
authored
Merge pull request #656 from mattcary/xfs-skew
Use node version on GKE when detecting XFS compatibility
2 parents b9c4467 + 982c56d commit c766b1f

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

test/k8s-integration/driver-config.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,14 @@ func generateDriverConfigFile(testParams *testParameters, storageClassFile strin
8686
switch testParams.deploymentStrategy {
8787
case "gke":
8888
if testParams.imageType == "cos" {
89-
gkeVer := mustParseVersion(testParams.clusterVersion)
89+
var gkeVer *version
90+
// The node version is what matters for XFS support. If the node version is not given, we assume
91+
// it's the same as the cluster master version.
92+
if testParams.nodeVersion != "" {
93+
gkeVer = mustParseVersion(testParams.nodeVersion)
94+
} else {
95+
gkeVer = mustParseVersion(testParams.clusterVersion)
96+
}
9097
if gkeVer.lessThan(mustParseVersion("1.18.0")) {
9198
// XFS is not supported on COS before 1.18.0
9299
} else {

test/k8s-integration/main.go

+2
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ type testParameters struct {
9494
allowedNotReadyNodes int
9595
useGKEManagedDriver bool
9696
clusterVersion string
97+
nodeVersion string
9798
imageType string
9899
}
99100

@@ -450,6 +451,7 @@ func handle() error {
450451
testParams.testSkip = generateGCETestSkip(testParams)
451452
case "gke":
452453
testParams.testSkip = generateGKETestSkip(testParams)
454+
testParams.nodeVersion = *gkeNodeVersion
453455
default:
454456
return fmt.Errorf("Unknown deployment strategy %s", testParams.deploymentStrategy)
455457
}

0 commit comments

Comments
 (0)