Skip to content

Commit ba9e0f0

Browse files
committed
Skip volume expansion test for node skew tests
1 parent 0a18035 commit ba9e0f0

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

test/k8s-integration/main.go

+10-2
Original file line numberDiff line numberDiff line change
@@ -513,6 +513,12 @@ func generateGCETestSkip(testParams *testParameters) string {
513513
if v.LessThan(apimachineryversion.MustParseSemantic("1.16.0")) {
514514
skipString = skipString + "|volumeMode\\sshould\\snot\\smount\\s/\\smap\\sunused\\svolumes\\sin\\sa\\spod"
515515
}
516+
517+
// ExpandCSIVolumes feature is beta in k8s 1.16
518+
if v.LessThan(apimachineryversion.MustParseSemantic("1.16.0")) {
519+
skipString = skipString + "|allowExpansion"
520+
}
521+
516522
if v.LessThan(apimachineryversion.MustParseSemantic("1.17.0")) {
517523
skipString = skipString + "|VolumeSnapshotDataSource"
518524
}
@@ -536,7 +542,7 @@ func generateGKETestSkip(testParams *testParameters) string {
536542
// "volumeMode should not mount / map unused volumes in a pod" tests a
537543
// (https://github.com/kubernetes/kubernetes/pull/81163)
538544
// bug-fix introduced in 1.16
539-
if curVer.lessThan(mustParseVersion("1.16.0")) {
545+
if curVer.lessThan(mustParseVersion("1.16.0")) || (nodeVer != nil && nodeVer.lessThan(mustParseVersion("1.16.0"))) {
540546
skipString = skipString + "|volumeMode\\sshould\\snot\\smount\\s/\\smap\\sunused\\svolumes\\sin\\sa\\spod"
541547
}
542548

@@ -545,9 +551,11 @@ func generateGKETestSkip(testParams *testParameters) string {
545551
skipString = skipString + "|fsgroupchangepolicy"
546552
}
547553

554+
// ExpandCSIVolumes feature is beta in k8s 1.16
548555
// For GKE deployed PD CSI driver, resizer sidecar is enabled in 1.16.8-gke.3
549556
if (testParams.useGKEManagedDriver && curVer.lessThan(mustParseVersion("1.16.8-gke.3"))) ||
550-
(!testParams.useGKEManagedDriver && curVer.lessThan(mustParseVersion("1.16.0"))) {
557+
(!testParams.useGKEManagedDriver && curVer.lessThan(mustParseVersion("1.16.0")) ||
558+
(nodeVer != nil && nodeVer.lessThan(mustParseVersion("1.16.0")))) {
551559
skipString = skipString + "|allowExpansion"
552560
}
553561

0 commit comments

Comments
 (0)