Skip to content

Commit b5c8138

Browse files
committed
remove invalid compute endpoint testcase as updated logic causes crash on invalid endpoint
1 parent 818302e commit b5c8138

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

pkg/gce-cloud-provider/compute/gce.go

-1
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ func getComputeVersion(ctx context.Context, tokenSource oauth2.TokenSource, comp
231231
_, err = url.ParseRequestURI(endpoint)
232232
if err != nil {
233233
klog.Fatalf("Error parsing compute endpoint %s", endpoint)
234-
return nil, err
235234
}
236235
computeOpts = append(computeOpts, option.WithEndpoint(endpoint))
237236
}

test/e2e/tests/single_zone_e2e_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1280,7 +1280,7 @@ var _ = Describe("GCE PD CSI Driver", func() {
12801280
}()
12811281
})
12821282

1283-
It("Should pass/fail if valid/invalid compute endpoint is passed in", func() {
1283+
It("Should pass if valid compute endpoint is passed in", func() {
12841284
// gets instance set up w/o compute-endpoint set from test setup
12851285
_, err := getRandomTestContext().Client.ListVolumes()
12861286
Expect(err).To(BeNil(), "no error expected when passed valid compute url")

0 commit comments

Comments
 (0)