Skip to content

Commit b25bedc

Browse files
committed
log operation id for attach and detach
1 parent 41bba8a commit b25bedc

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

pkg/gce-cloud-provider/compute/gce-compute.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,7 @@ func (cloud *CloudProvider) insertRegionalDisk(
421421
insertOp, err = cloud.service.RegionDisks.Insert(project, volKey.Region, diskToCreate).Context(ctx).Do()
422422
if insertOp != nil {
423423
opName = insertOp.Name
424+
klog.V(5).Infof("InsertDisk operation %v", opName)
424425
}
425426
}
426427
if err != nil {
@@ -515,6 +516,7 @@ func (cloud *CloudProvider) insertZonalDisk(
515516
insertOp, err = cloud.service.Disks.Insert(project, volKey.Zone, diskToCreate).Context(ctx).Do()
516517
if insertOp != nil {
517518
opName = insertOp.Name
519+
klog.V(5).Infof("InsertDisk operation %v", opName)
518520
}
519521
}
520522

@@ -574,6 +576,7 @@ func (cloud *CloudProvider) DeleteDisk(ctx context.Context, project string, volK
574576

575577
func (cloud *CloudProvider) deleteZonalDisk(ctx context.Context, project, zone, name string) error {
576578
op, err := cloud.service.Disks.Delete(project, zone, name).Context(ctx).Do()
579+
klog.V(5).Infof("DeleteDisk operation %v", op.Name)
577580
if err != nil {
578581
if IsGCEError(err, "notFound") {
579582
// Already deleted
@@ -590,6 +593,7 @@ func (cloud *CloudProvider) deleteZonalDisk(ctx context.Context, project, zone,
590593

591594
func (cloud *CloudProvider) deleteRegionalDisk(ctx context.Context, project, region, name string) error {
592595
op, err := cloud.service.RegionDisks.Delete(project, region, name).Context(ctx).Do()
596+
klog.V(5).Infof("DeleteDisk operation %v", op.Name)
593597
if err != nil {
594598
if IsGCEError(err, "notFound") {
595599
// Already deleted
@@ -621,6 +625,7 @@ func (cloud *CloudProvider) AttachDisk(ctx context.Context, project string, volK
621625
}
622626

623627
op, err := cloud.service.Instances.AttachDisk(project, instanceZone, instanceName, attachedDiskV1).Context(ctx).Do()
628+
klog.V(5).Infof("AttachDisk operation %v", op.Name)
624629
if err != nil {
625630
return fmt.Errorf("failed cloud service attach disk call: %v", err)
626631
}
@@ -634,6 +639,7 @@ func (cloud *CloudProvider) AttachDisk(ctx context.Context, project string, volK
634639
func (cloud *CloudProvider) DetachDisk(ctx context.Context, project, deviceName, instanceZone, instanceName string) error {
635640
klog.V(5).Infof("Detaching disk %v from %v", deviceName, instanceName)
636641
op, err := cloud.service.Instances.DetachDisk(project, instanceZone, instanceName, deviceName).Context(ctx).Do()
642+
klog.V(5).Infof("DetachDisk operation %v", op.Name)
637643
if err != nil {
638644
return err
639645
}
@@ -846,6 +852,7 @@ func (cloud *CloudProvider) resizeZonalDisk(ctx context.Context, project string,
846852
SizeGb: requestGb,
847853
}
848854
op, err := cloud.service.Disks.Resize(project, volKey.Zone, volKey.Name, resizeReq).Context(ctx).Do()
855+
klog.V(5).Infof("ResizeDisk operation %v", op.Name)
849856
if err != nil {
850857
return -1, fmt.Errorf("failed to resize zonal volume %v: %v", volKey.String(), err)
851858
}
@@ -862,8 +869,8 @@ func (cloud *CloudProvider) resizeRegionalDisk(ctx context.Context, project stri
862869
resizeReq := &computev1.RegionDisksResizeRequest{
863870
SizeGb: requestGb,
864871
}
865-
866872
op, err := cloud.service.RegionDisks.Resize(project, volKey.Region, volKey.Name, resizeReq).Context(ctx).Do()
873+
klog.V(5).Infof("ResizeDisk operation %v", op.Name)
867874
if err != nil {
868875
return -1, fmt.Errorf("failed to resize regional volume %v: %v", volKey.String(), err)
869876
}

0 commit comments

Comments
 (0)