Skip to content

Commit b1abbde

Browse files
committed
lower threshold on backoff for sanity tests
1 parent cd8a6d2 commit b1abbde

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

cmd/gce-pd-csi-driver/main.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ var (
5757

5858
maxprocs = flag.Int("maxprocs", 1, "GOMAXPROCS override")
5959

60+
errorBackoffInitialDuration = 200 * time.Millisecond
61+
6062
version string
6163
)
6264

@@ -122,7 +124,7 @@ func handle() {
122124
if err != nil {
123125
klog.Fatalf("Failed to get cloud provider: %v", err)
124126
}
125-
controllerServer = driver.NewControllerServer(gceDriver, cloudProvider)
127+
controllerServer = driver.NewControllerServer(gceDriver, cloudProvider, errorBackoffInitialDuration)
126128
} else if *cloudConfigFilePath != "" {
127129
klog.Warningf("controller service is disabled but cloud config given - it has no effect")
128130
}

pkg/gce-pd-csi-driver/controller.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -1596,8 +1596,8 @@ func pickRandAndConsecutive(slice []string, n int) ([]string, error) {
15961596
return ret, nil
15971597
}
15981598

1599-
func newCsiErrorBackoff() *csiErrorBackoff {
1600-
return &csiErrorBackoff{flowcontrol.NewBackOff(errorBackoffInitialDuration, errorBackoffMaxDuration)}
1599+
func newCsiErrorBackoff(initialDuration time.Duration) *csiErrorBackoff {
1600+
return &csiErrorBackoff{flowcontrol.NewBackOff(initialDuration, errorBackoffMaxDuration)}
16011601
}
16021602

16031603
func (_ *csiErrorBackoff) backoffId(nodeId, volumeId string) csiErrorBackoffId {

pkg/gce-pd-csi-driver/gce-pd-driver.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ package gceGCEDriver
1616

1717
import (
1818
"fmt"
19+
"time"
1920

2021
csi "github.com/container-storage-interface/spec/lib/go/csi"
2122
"google.golang.org/grpc/codes"
@@ -148,13 +149,13 @@ func NewNodeServer(gceDriver *GCEDriver, mounter *mount.SafeFormatAndMount, devi
148149
}
149150
}
150151

151-
func NewControllerServer(gceDriver *GCEDriver, cloudProvider gce.GCECompute) *GCEControllerServer {
152+
func NewControllerServer(gceDriver *GCEDriver, cloudProvider gce.GCECompute, errorBackoffInitialDuration time.Duration) *GCEControllerServer {
152153
return &GCEControllerServer{
153154
Driver: gceDriver,
154155
CloudProvider: cloudProvider,
155156
seen: map[string]int{},
156157
volumeLocks: common.NewVolumeLocks(),
157-
errorBackoff: newCsiErrorBackoff(),
158+
errorBackoff: newCsiErrorBackoff(errorBackoffInitialDuration),
158159
}
159160
}
160161

pkg/gce-pd-csi-driver/gce-pd-driver_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func initBlockingGCEDriver(t *testing.T, cloudDisks []*gce.CloudDisk, readyToExe
4343
func initGCEDriverWithCloudProvider(t *testing.T, cloudProvider gce.GCECompute) *GCEDriver {
4444
vendorVersion := "test-vendor"
4545
gceDriver := GetGCEDriver()
46-
controllerServer := NewControllerServer(gceDriver, cloudProvider)
46+
controllerServer := NewControllerServer(gceDriver, cloudProvider, errorBackoffInitialDuration)
4747
err := gceDriver.SetupGCEDriver(driver, vendorVersion, nil, nil, controllerServer, nil)
4848
if err != nil {
4949
t.Fatalf("Failed to setup GCE Driver: %v", err)

test/sanity/sanity_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"path"
2222
"strings"
2323
"testing"
24+
"time"
2425

2526
"github.com/google/uuid"
2627
"google.golang.org/grpc"
@@ -64,7 +65,7 @@ func TestSanity(t *testing.T) {
6465

6566
//Initialize GCE Driver
6667
identityServer := driver.NewIdentityServer(gceDriver)
67-
controllerServer := driver.NewControllerServer(gceDriver, cloudProvider)
68+
controllerServer := driver.NewControllerServer(gceDriver, cloudProvider, 1 * time.Millisecond)
6869
nodeServer := driver.NewNodeServer(gceDriver, mounter, deviceUtils, metadataservice.NewFakeService(), mountmanager.NewFakeStatter(mounter))
6970
err = gceDriver.SetupGCEDriver(driverName, vendorVersion, extraLabels, identityServer, controllerServer, nodeServer)
7071
if err != nil {

0 commit comments

Comments
 (0)