Skip to content

Commit a69cc83

Browse files
authored
Merge pull request #732 from TeweiLuo/full-cluster-name
Add a param for full GKE cluster name.
2 parents 7031ece + 609b733 commit a69cc83

File tree

1 file changed

+23
-20
lines changed

1 file changed

+23
-20
lines changed

test/k8s-integration/main.go

+23-20
Original file line numberDiff line numberDiff line change
@@ -32,24 +32,25 @@ import (
3232

3333
var (
3434
// Kubernetes cluster flags
35-
teardownCluster = flag.Bool("teardown-cluster", true, "teardown the cluster after the e2e test")
36-
teardownDriver = flag.Bool("teardown-driver", true, "teardown the driver after the e2e test")
37-
bringupCluster = flag.Bool("bringup-cluster", true, "build kubernetes and bringup a cluster")
38-
platform = flag.String("platform", "linux", "platform that the tests will be run, either linux or windows")
39-
gceZone = flag.String("gce-zone", "", "zone that the gce k8s cluster is created/found in")
40-
gceRegion = flag.String("gce-region", "", "region that gke regional cluster should be created in")
41-
kubeVersion = flag.String("kube-version", "", "version of Kubernetes to download and use for the cluster")
42-
testVersion = flag.String("test-version", "", "version of Kubernetes to download and use for tests")
43-
kubeFeatureGates = flag.String("kube-feature-gates", "", "feature gates to set on new kubernetes cluster")
44-
localK8sDir = flag.String("local-k8s-dir", "", "local prebuilt kubernetes/kubernetes directory to use for cluster and test binaries")
45-
deploymentStrat = flag.String("deployment-strategy", "gce", "choose between deploying on gce or gke")
46-
gkeClusterVer = flag.String("gke-cluster-version", "", "version of Kubernetes master and node for gke")
47-
numNodes = flag.Int("num-nodes", -1, "the number of nodes in the test cluster")
48-
imageType = flag.String("image-type", "cos", "the image type to use for the cluster")
49-
gkeReleaseChannel = flag.String("gke-release-channel", "", "GKE release channel to be used for cluster deploy. One of 'rapid', 'stable' or 'regular'")
50-
gkeTestClusterName = flag.String("gke-cluster-name", "pdcsi", "Prefix of GKE cluster names. A random suffix will be appended to form the full name.")
51-
gkeNodeVersion = flag.String("gke-node-version", "", "GKE cluster worker node version")
52-
isRegionalCluster = flag.Bool("is-regional-cluster", false, "tell the test that a regional cluster is being used. Should be used for running on an existing regional cluster (ie, --bringup-cluster=false). The test will fail if a zonal GKE cluster is created when this flag is true")
35+
teardownCluster = flag.Bool("teardown-cluster", true, "teardown the cluster after the e2e test")
36+
teardownDriver = flag.Bool("teardown-driver", true, "teardown the driver after the e2e test")
37+
bringupCluster = flag.Bool("bringup-cluster", true, "build kubernetes and bringup a cluster")
38+
platform = flag.String("platform", "linux", "platform that the tests will be run, either linux or windows")
39+
gceZone = flag.String("gce-zone", "", "zone that the gce k8s cluster is created/found in")
40+
gceRegion = flag.String("gce-region", "", "region that gke regional cluster should be created in")
41+
kubeVersion = flag.String("kube-version", "", "version of Kubernetes to download and use for the cluster")
42+
testVersion = flag.String("test-version", "", "version of Kubernetes to download and use for tests")
43+
kubeFeatureGates = flag.String("kube-feature-gates", "", "feature gates to set on new kubernetes cluster")
44+
localK8sDir = flag.String("local-k8s-dir", "", "local prebuilt kubernetes/kubernetes directory to use for cluster and test binaries")
45+
deploymentStrat = flag.String("deployment-strategy", "gce", "choose between deploying on gce or gke")
46+
gkeClusterVer = flag.String("gke-cluster-version", "", "version of Kubernetes master and node for gke")
47+
numNodes = flag.Int("num-nodes", -1, "the number of nodes in the test cluster")
48+
imageType = flag.String("image-type", "cos", "the image type to use for the cluster")
49+
gkeReleaseChannel = flag.String("gke-release-channel", "", "GKE release channel to be used for cluster deploy. One of 'rapid', 'stable' or 'regular'")
50+
gkeTestClusterPrefix = flag.String("gke-cluster-prefix", "pdcsi", "Prefix of GKE cluster names. A random suffix will be appended to form the full name.")
51+
gkeTestClusterName = flag.String("gke-cluster-name", "", "Name of existing cluster")
52+
gkeNodeVersion = flag.String("gke-node-version", "", "GKE cluster worker node version")
53+
isRegionalCluster = flag.Bool("is-regional-cluster", false, "tell the test that a regional cluster is being used. Should be used for running on an existing regional cluster (ie, --bringup-cluster=false). The test will fail if a zonal GKE cluster is created when this flag is true")
5354

5455
// Test infrastructure flags
5556
boskosResourceType = flag.String("boskos-resource-type", "gce-project", "name of the boskos resource type to reserve")
@@ -164,8 +165,10 @@ func main() {
164165
if len(*localK8sDir) == 0 {
165166
ensureVariable(testVersion, true, "Must set either test-version or local k8s dir when using deployment strategy 'gke'.")
166167
}
167-
randSuffix := string(uuid.NewUUID())[0:4]
168-
*gkeTestClusterName += randSuffix
168+
if len(*gkeTestClusterName) == 0 {
169+
randSuffix := string(uuid.NewUUID())[0:4]
170+
*gkeTestClusterName = *gkeTestClusterPrefix + randSuffix
171+
}
169172
} else if *deploymentStrat == "gce" {
170173
ensureVariable(gceRegion, false, "regional clusters not supported for 'gce' deployment")
171174
ensureVariable(gceZone, true, "gce-zone required for 'gce' deployment")

0 commit comments

Comments
 (0)