Skip to content

Commit a30cd65

Browse files
committed
Makefile s/gce/gce-pd, added TODO, changed metadata.Zone() call
1 parent 9c3112c commit a30cd65

File tree

2 files changed

+12
-17
lines changed

2 files changed

+12
-17
lines changed

Makefile

+10-10
Original file line numberDiff line numberDiff line change
@@ -12,31 +12,31 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
STAGINGIMAGE=gcr.io/dyzz-csi-staging/csi/gce-driver
15+
STAGINGIMAGE=gcr.io/dyzz-csi-staging/csi/gce-pd-driver
1616
STAGINGVERSION=latest
1717

1818
PRODIMAGE=gcr.io/google-containers/volume-csi/compute-persistent-disk-csi-driver
1919
PRODVERSION=v0.2.0.alpha
20-
all: gce-driver
20+
all: gce-pd-driver
2121

22-
gce-driver:
22+
gce-pd-driver:
2323
mkdir -p bin
24-
go build -o bin/gce-csi-driver ./cmd/
25-
go build -o bin/gce-csi-driver-test ./test/e2e/
24+
go build -o bin/gce-pd-csi-driver ./cmd/
25+
go build -o bin/gce-pd-csi-driver-test ./test/e2e/
2626

27-
build-container: gce-driver
28-
cp bin/gce-csi-driver deploy/docker
27+
build-container: gce-pd-driver
28+
cp bin/gce-pd-csi-driver deploy/docker
2929
docker build -t $(STAGINGIMAGE):$(STAGINGVERSION) deploy/docker
3030

3131
push-container: build-container
3232
gcloud docker -- push $(STAGINGIMAGE):$(STAGINGVERSION)
3333

34-
prod-build-container: gce-driver
35-
cp bin/gce-csi-driver deploy/docker
34+
prod-build-container: gce-pd-driver
35+
cp bin/gce-pd-csi-driver deploy/docker
3636
docker build -t $(PRODIMAGE):$(PRODVERSION) deploy/docker
3737

3838
prod-push-container: prod-build-container
3939
gcloud docker -- push $(PRODIMAGE):$(PRODVERSION)
4040

41-
test-sanity: gce-driver
41+
test-sanity: gce-pd-driver
4242
go test -timeout 30s github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pkg/test -run ^TestSanity$

pkg/gce-cloud-provider/gce.go

+2-7
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import (
1919
"net/http"
2020
"os"
2121
"runtime"
22-
"strings"
2322
"time"
2423

2524
"cloud.google.com/go/compute/metadata"
@@ -80,6 +79,7 @@ func createCloudServiceWithDefaultServiceAccount() (*compute.Service, error) {
8079
if err != nil {
8180
return nil, err
8281
}
82+
// TODO(dyzz) parameterize version number
8383
service.UserAgent = fmt.Sprintf("GCE CSI Driver/%s (%s %s)", "0.2.0", runtime.GOOS, runtime.GOARCH)
8484
return service, nil
8585
}
@@ -114,15 +114,10 @@ func newDefaultOauthClient() (*http.Client, error) {
114114
}
115115

116116
func getProjectAndZoneFromMetadata() (string, string, error) {
117-
result, err := metadata.Get("instance/zone")
117+
zone, err := metadata.Zone()
118118
if err != nil {
119119
return "", "", err
120120
}
121-
parts := strings.Split(result, "/")
122-
if len(parts) != 4 {
123-
return "", "", fmt.Errorf("unexpected response: %s", result)
124-
}
125-
zone := parts[3]
126121
projectID, err := metadata.ProjectID()
127122
if err != nil {
128123
return "", "", err

0 commit comments

Comments
 (0)