Skip to content

Commit 843b082

Browse files
authored
Merge pull request #1126 from mauriciopoppe/multi-arch-build-windows
fix: remove linux/arm64 and windows/amd64 20h2 from multi-arch build
2 parents a5f4bb0 + 2a198f8 commit 843b082

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

Makefile

+3-10
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,10 @@ DRIVERWINDOWSBINARY=${DRIVERBINARY}.exe
2424
DOCKER=DOCKER_CLI_EXPERIMENTAL=enabled docker
2525

2626
BASE_IMAGE_LTSC2019=mcr.microsoft.com/windows/servercore:ltsc2019
27-
BASE_IMAGE_20H2=mcr.microsoft.com/windows/servercore:20H2
2827

2928
# Both arrays MUST be index aligned.
30-
WINDOWS_IMAGE_TAGS=ltsc2019 20H2
31-
WINDOWS_BASE_IMAGES=$(BASE_IMAGE_LTSC2019) $(BASE_IMAGE_20H2)
29+
WINDOWS_IMAGE_TAGS=ltsc2019
30+
WINDOWS_BASE_IMAGES=$(BASE_IMAGE_LTSC2019)
3231

3332
GCFLAGS=""
3433
ifdef GCE_PD_CSI_DEBUG
@@ -61,14 +60,8 @@ build-and-push-windows-container-ltsc2019: require-GCE_PD_CSI_STAGING_IMAGE init
6160
--build-arg BASE_IMAGE=$(BASE_IMAGE_LTSC2019) \
6261
--build-arg STAGINGVERSION=$(STAGINGVERSION) --push .
6362

64-
build-and-push-windows-container-20H2: require-GCE_PD_CSI_STAGING_IMAGE init-buildx
65-
$(DOCKER) buildx build --file=Dockerfile.Windows --platform=windows \
66-
-t $(STAGINGIMAGE):$(STAGINGVERSION)_20H2 \
67-
--build-arg BASE_IMAGE=$(BASE_IMAGE_20H2) \
68-
--build-arg STAGINGVERSION=$(STAGINGVERSION) --push .
69-
7063
build-and-push-multi-arch: build-and-push-container-linux-amd64 build-and-push-windows-container-ltsc2019
71-
$(DOCKER) manifest create --amend $(STAGINGIMAGE):$(STAGINGVERSION) $(STAGINGIMAGE):$(STAGINGVERSION)_linux_amd64 $(STAGINGIMAGE):$(STAGINGVERSION)_linux_arm64 $(STAGINGIMAGE):$(STAGINGVERSION)_20H2 $(STAGINGIMAGE):$(STAGINGVERSION)_ltsc2019
64+
$(DOCKER) manifest create --amend $(STAGINGIMAGE):$(STAGINGVERSION) $(STAGINGIMAGE):$(STAGINGVERSION)_linux_amd64 $(STAGINGIMAGE):$(STAGINGVERSION)_ltsc2019
7265
STAGINGIMAGE="$(STAGINGIMAGE)" STAGINGVERSION="$(STAGINGVERSION)" WINDOWS_IMAGE_TAGS="$(WINDOWS_IMAGE_TAGS)" WINDOWS_BASE_IMAGES="$(WINDOWS_BASE_IMAGES)" ./manifest_osversion.sh
7366
$(DOCKER) manifest push -p $(STAGINGIMAGE):$(STAGINGVERSION)
7467

0 commit comments

Comments
 (0)