Completley removing the multiwriter check from fake-gce.

sjswerdlow · sjswerdlow · commit 81ce104d08f5 · 2025-01-23T17:03:58.000Z
diff --git a/pkg/gce-cloud-provider/compute/fake-gce.go b/pkg/gce-cloud-provider/compute/fake-gce.go
@@ -212,11 +212,6 @@ func (cloud *FakeCloudProvider) ValidateExistingDisk(ctx context.Context, resp *
 			params.DiskType, respType[len(respType)-1])
 	}
 
-	// We are assuming here that a multiWriter disk could be used as non-multiWriter
-	if multiWriter {
-		return fmt.Errorf("disk already exists with incompatible capability. Need MultiWriter. Got non-MultiWriter")
-	}
-
 	klog.V(4).Infof("Compatible disk already exists")
 	return ValidateDiskParameters(resp, params)
 }

Original file line number	Diff line number	Diff line change
`@@ -212,11 +212,6 @@ func (cloud FakeCloudProvider) ValidateExistingDisk(ctx context.Context, resp `
`212`	`212`	`params.DiskType, respType[len(respType)-1])`
`213`	`213`	`}`
`214`	`214`
`215`		`- // We are assuming here that a multiWriter disk could be used as non-multiWriter`
`216`		`- if multiWriter {`
`217`		`- return fmt.Errorf("disk already exists with incompatible capability. Need MultiWriter. Got non-MultiWriter")`
`218`		`- }`
`219`		`-`
`220`	`215`	`klog.V(4).Infof("Compatible disk already exists")`
`221`	`216`	`return ValidateDiskParameters(resp, params)`
`222`	`217`	`}`