Skip to content

Commit 7ea52f7

Browse files
authored
Merge pull request #428 from davidz627/fix/removeStrip
Remove protosanitizer.StripSecrets since the PD driver doesn't use controller or node call secrets and the StripSecrets call is expensive
2 parents fa208e7 + 427bde2 commit 7ea52f7

File tree

6 files changed

+3
-686
lines changed

6 files changed

+3
-686
lines changed

Gopkg.lock

+1-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/gce-pd-csi-driver/utils.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
"context"
2424

2525
csi "github.com/container-storage-interface/spec/lib/go/csi"
26-
"github.com/kubernetes-csi/csi-lib-utils/protosanitizer"
2726
"google.golang.org/grpc"
2827
"k8s.io/klog"
2928
)
@@ -53,12 +52,12 @@ func NewNodeServiceCapability(cap csi.NodeServiceCapability_RPC_Type) *csi.NodeS
5352
}
5453

5554
func logGRPC(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {
56-
klog.V(4).Infof("%s called with request: %+v", info.FullMethod, protosanitizer.StripSecrets(req))
55+
klog.V(4).Infof("%s called with request: %+v", info.FullMethod, req)
5756
resp, err := handler(ctx, req)
5857
if err != nil {
5958
klog.Errorf("%s returned with error: %v", info.FullMethod, err)
6059
} else {
61-
klog.V(4).Infof("%s returned with response: %+v", info.FullMethod, protosanitizer.StripSecrets(resp))
60+
klog.V(4).Infof("%s returned with response: %+v", info.FullMethod, resp)
6261
}
6362
return resp, err
6463
}

vendor/github.com/golang/protobuf/descriptor/descriptor.go

-93
This file was deleted.

vendor/github.com/kubernetes-csi/csi-lib-utils/LICENSE

-201
This file was deleted.

0 commit comments

Comments
 (0)