Skip to content

Commit 71387ca

Browse files
authored
Merge pull request #603 from saikat-royc/node-version-skew
e2e test should take GKE node version as an input
2 parents c152149 + b45161e commit 71387ca

File tree

4 files changed

+14
-0
lines changed

4 files changed

+14
-0
lines changed

test/k8s-integration/cluster.go

+4
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,10 @@ func clusterUpGKE(gceZone, gceRegion string, numNodes int, imageType string, use
167167
cmdParams = append(cmdParams, "--enable-autorepair")
168168
}
169169

170+
if isVariableSet(gkeNodeVersion) {
171+
cmdParams = append(cmdParams, "--node-version", *gkeNodeVersion)
172+
}
173+
170174
if useManagedDriver {
171175
// PD CSI Driver add on is enabled only in gcloud beta.
172176
cmdParams = append([]string{"beta"}, cmdParams...)

test/k8s-integration/main.go

+1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ var (
4848
imageType = flag.String("image-type", "cos", "the image type to use for the cluster")
4949
gkeReleaseChannel = flag.String("gke-release-channel", "", "GKE release channel to be used for cluster deploy. One of 'rapid', 'stable' or 'regular'")
5050
gkeTestClusterName = flag.String("gke-cluster-name", "gcp-pd-csi-driver-test-cluster", "GKE cluster name")
51+
gkeNodeVersion = flag.String("gke-node-version", "", "GKE cluster worker node version")
5152

5253
// Test infrastructure flags
5354
boskosResourceType = flag.String("boskos-resource-type", "gce-project", "name of the boskos resource type to reserve")

test/run-k8s-integration-ci.sh

+5
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ readonly image_type=${IMAGE_TYPE:-cos}
2323
readonly use_gke_managed_driver=${USE_GKE_MANAGED_DRIVER:-false}
2424
readonly gke_release_channel=${GKE_RELEASE_CHANNEL:-""}
2525
readonly teardown_driver=${GCE_PD_TEARDOWN_DRIVER:-true}
26+
readonly gke_node_version=${GKE_NODE_VERSION:-}
2627

2728
export GCE_PD_VERBOSITY=9
2829

@@ -57,4 +58,8 @@ else
5758
base_cmd="${base_cmd} --gce-region=${gce_region}"
5859
fi
5960

61+
if [ -z "$gke_node_version" ]; then
62+
base_cmd="${base_cmd} --gke-node-version=${gke_node_version}"
63+
fi
64+
6065
eval "$base_cmd"

test/run-k8s-integration.sh

+4
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ readonly image_type=${IMAGE_TYPE:-cos}
2323
readonly use_gke_managed_driver=${USE_GKE_MANAGED_DRIVER:-false}
2424
readonly gke_release_channel=${GKE_RELEASE_CHANNEL:-""}
2525
readonly teardown_driver=${GCE_PD_TEARDOWN_DRIVER:-true}
26+
readonly gke_node_version=${GKE_NODE_VERSION:-}
2627

2728
export GCE_PD_VERBOSITY=9
2829

@@ -57,4 +58,7 @@ else
5758
base_cmd="${base_cmd} --gce-region=${gce_region}"
5859
fi
5960

61+
if [ -z "$gke_node_version" ]; then
62+
base_cmd="${base_cmd} --gke-node-version=${gke_node_version}"
63+
fi
6064
eval "$base_cmd"

0 commit comments

Comments
 (0)