Skip to content

Commit 60e1cd3

Browse files
authored
Merge pull request #98 from pohly/kubernetes-1-19-fixes
Kubernetes 1.19 fixes
2 parents 1fbb636 + 0979c09 commit 60e1cd3

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

Diff for: prow.sh

+16-11
Original file line numberDiff line numberDiff line change
@@ -218,17 +218,18 @@ configvar CSI_PROW_DRIVER_CANARY "${CSI_PROW_HOSTPATH_CANARY}" "driver image ove
218218
# all generated files are present.
219219
#
220220
# CSI_PROW_E2E_REPO=none disables E2E testing.
221-
# TOOO: remove versioned variables and make e2e version match k8s version
222-
configvar CSI_PROW_E2E_VERSION_1_15 v1.15.0 "E2E version for Kubernetes 1.15.x"
223-
configvar CSI_PROW_E2E_VERSION_1_16 v1.16.0 "E2E version for Kubernetes 1.16.x"
224-
configvar CSI_PROW_E2E_VERSION_1_17 v1.17.0 "E2E version for Kubernetes 1.17.x"
225-
# TODO: add new CSI_PROW_E2E_VERSION entry for future Kubernetes releases
226-
configvar CSI_PROW_E2E_VERSION_LATEST master "E2E version for Kubernetes master" # testing against Kubernetes master is already tracking a moving target, so we might as well use a moving E2E version
227-
configvar CSI_PROW_E2E_REPO_LATEST https://github.com/kubernetes/kubernetes "E2E repo for Kubernetes >= 1.13.x" # currently the same for all versions
228-
configvar CSI_PROW_E2E_IMPORT_PATH_LATEST k8s.io/kubernetes "E2E package for Kubernetes >= 1.13.x" # currently the same for all versions
229-
configvar CSI_PROW_E2E_VERSION "$(get_versioned_variable CSI_PROW_E2E_VERSION "${csi_prow_kubernetes_version_suffix}")" "E2E version"
230-
configvar CSI_PROW_E2E_REPO "$(get_versioned_variable CSI_PROW_E2E_REPO "${csi_prow_kubernetes_version_suffix}")" "E2E repo"
231-
configvar CSI_PROW_E2E_IMPORT_PATH "$(get_versioned_variable CSI_PROW_E2E_IMPORT_PATH "${csi_prow_kubernetes_version_suffix}")" "E2E package"
221+
tag_from_version () {
222+
version="$1"
223+
shift
224+
case "$version" in
225+
latest) echo "master";;
226+
release-*) echo "$version";;
227+
*) echo "v$version";;
228+
esac
229+
}
230+
configvar CSI_PROW_E2E_VERSION "$(tag_from_version "${CSI_PROW_KUBERNETES_VERSION}")" "E2E version"
231+
configvar CSI_PROW_E2E_REPO "https://github.com/kubernetes/kubernetes" "E2E repo"
232+
configvar CSI_PROW_E2E_IMPORT_PATH "k8s.io/kubernetes" "E2E package"
232233

233234
# csi-sanity testing from the csi-test repo can be run against the installed
234235
# CSI driver. For this to work, deploying the driver must expose the Unix domain
@@ -513,6 +514,10 @@ go_version_for_kubernetes () (
513514
if ! [ "$go_version" ]; then
514515
die "Unable to determine Go version for Kubernetes $version from hack/lib/golang.sh."
515516
fi
517+
# Strip the trailing .0. Kubernetes includes it, Go itself doesn't.
518+
# Ignore: See if you can use ${variable//search/replace} instead.
519+
# shellcheck disable=SC2001
520+
go_version="$(echo "$go_version" | sed -e 's/\.0$//')"
516521
echo "$go_version"
517522
)
518523

0 commit comments

Comments
 (0)