Skip to content

Commit 5d2971b

Browse files
committed
Run the k8s-integration-test binary without eval
1 parent c536d7e commit 5d2971b

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

test/run-windows-k8s-integration.sh

+2-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ if [ "$use_kubetest2" = true ]; then
3434
go install sigs.k8s.io/kubetest2/kubetest2-tester-ginkgo@latest;
3535
fi
3636

37-
base_cmd="${PKGDIR}/bin/k8s-integration-test \
37+
${PKGDIR}/bin/k8s-integration-test \
3838
--run-in-prow=true \
3939
--service-account-file=${E2E_GOOGLE_APPLICATION_CREDENTIALS} \
4040
--boskos-resource-type=${boskos_resource_type} \
@@ -53,6 +53,4 @@ base_cmd="${PKGDIR}/bin/k8s-integration-test \
5353
--storageclass-files=sc-windows.yaml \
5454
--snapshotclass-file=pd-volumesnapshotclass.yaml \
5555
--test-focus='External.Storage' \
56-
--use-kubetest2=${use_kubetest2}"
57-
58-
eval "$base_cmd"
56+
--use-kubetest2=${use_kubetest2}

test/run-windows-k8s-migration.sh

+2-4
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ readonly GCE_PD_TEST_FOCUS="PersistentVolumes\sGCEPD|[V|v]olume\sexpand|\[sig-st
4141

4242
# TODO(#167): Enable reconstructions tests
4343

44-
base_cmd="${PKGDIR}/bin/k8s-integration-test \
44+
${PKGDIR}/bin/k8s-integration-test \
4545
--run-in-prow=true \
4646
--service-account-file=${E2E_GOOGLE_APPLICATION_CREDENTIALS} \
4747
--boskos-resource-type=${boskos_resource_type} \
@@ -61,6 +61,4 @@ base_cmd="${PKGDIR}/bin/k8s-integration-test \
6161
--storageclass-files=sc-windows.yaml \
6262
--snapshotclass-file=pd-volumesnapshotclass.yaml \
6363
--test-focus=${GCE_PD_TEST_FOCUS} \
64-
--use-kubetest2=${use_kubetest2}"
65-
66-
eval "$base_cmd"
64+
--use-kubetest2=${use_kubetest2}

0 commit comments

Comments
 (0)