Skip to content

Commit 56b34e3

Browse files
committed
fix test suite issue
1 parent a6420e8 commit 56b34e3

File tree

1 file changed

+20
-13
lines changed

1 file changed

+20
-13
lines changed

test/e2e/tests/setup_e2e_test.go

+20-13
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ var _ = BeforeSuite(func() {
8181
defer close(hdtcc)
8282

8383
zones := strings.Split(*zones, ",")
84-
// Create 2 instances for each zone as we need 2 instances each zone for certain test cases
85-
8684
rand.Seed(time.Now().UnixNano())
8785

8886
computeService, err = remote.GetComputeClient()
@@ -109,27 +107,31 @@ var _ = BeforeSuite(func() {
109107

110108
numberOfInstancesPerZone := 2
111109

112-
setupContext := func(zones []string, randInt int) {
113-
for _, zone := range zones {
114-
go func(curZone string) {
110+
setupContext := func(zone string) {
111+
// Create 2 instances for each zone as we need 2 instances each zone for certain test cases
112+
for j := 0; j < numberOfInstancesPerZone; j++ {
113+
go func(curZone string, randInt int) {
115114
defer GinkgoRecover()
116115
tcc <- NewDefaultTestContext(curZone, strconv.Itoa(randInt))
117-
}(zone)
118-
go func(curZone string) {
119-
defer GinkgoRecover()
120-
hdtcc <- NewTestContext(curZone, *hdMinCpuPlatform, *hdMachineType, strconv.Itoa(randInt))
121-
}(zone)
116+
}(zone, j)
122117
}
118+
go func(curZone string) {
119+
defer GinkgoRecover()
120+
hdtcc <- NewTestContext(curZone, *hdMinCpuPlatform, *hdMachineType, "0")
121+
}(zone)
123122
}
124-
for j := 0; j < numberOfInstancesPerZone; j++ {
125-
setupContext(zones, j)
123+
124+
for _, zone := range zones {
125+
setupContext(zone)
126126
}
127127

128128
for i := 0; i < len(zones)*numberOfInstancesPerZone; i++ {
129129
tc := <-tcc
130130
testContexts = append(testContexts, tc)
131131
klog.Infof("Added TestContext for node %s", tc.Instance.GetName())
132-
tc = <-hdtcc
132+
}
133+
for i := 0; i < len(zones); i++ {
134+
tc := <-hdtcc
133135
hyperdiskTestContexts = append(hyperdiskTestContexts, tc)
134136
klog.Infof("Added TestContext for node %s", tc.Instance.GetName())
135137
}
@@ -178,6 +180,11 @@ func NewTestContext(zone, minCpuPlatform, machineType string, instanceNumber str
178180
ComputeService: computeService,
179181
LocalSSDCount: localSSDCount,
180182
}
183+
184+
if machineType == *hdMachineType {
185+
// Machine type is defaulted to c3-standard-2 which doesn't support LSSD and we don't need LSSD for HdHA test context
186+
instanceConfig.LocalSSDCount = 0
187+
}
181188
i, err := remote.SetupInstance(instanceConfig)
182189
if err != nil {
183190
klog.Fatalf("Failed to setup instance %v: %v", nodeID, err)

0 commit comments

Comments
 (0)