Skip to content

Commit 558508c

Browse files
authored
Merge pull request #909 from mattcary/containerd
use cos_containerd as default image
2 parents 971f131 + 59d9767 commit 558508c

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

test/k8s-integration/cluster.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,9 @@ func clusterUpGCE(k8sDir, gceZone string, numNodes int, numWindowsNodes int, ima
135135
func setImageTypeEnvs(imageType string) error {
136136
switch strings.ToLower(imageType) {
137137
case "cos":
138+
case "cos_containerd":
138139
case "gci": // GCI/COS is default type and does not need env vars set
139-
case "ubuntu":
140+
case "ubuntu", "ubuntu_containerd":
140141
return errors.New("setting environment vars for bringing up *ubuntu* cluster on GCE is unimplemented")
141142
/* TODO(dyzz) figure out how to bring up a Ubuntu cluster on GCE. The below doesn't work.
142143
err := os.Setenv("KUBE_OS_DISTRIBUTION", "ubuntu")

test/k8s-integration/main.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ var (
4747
gkeClusterVer = flag.String("gke-cluster-version", "", "version of Kubernetes master and node for gke")
4848
numNodes = flag.Int("num-nodes", 0, "the number of nodes in the test cluster")
4949
numWindowsNodes = flag.Int("num-windows-nodes", 0, "the number of Windows nodes in the test cluster")
50-
imageType = flag.String("image-type", "cos", "the image type to use for the cluster")
50+
imageType = flag.String("image-type", "cos_containerd", "the image type to use for the cluster")
5151
gkeReleaseChannel = flag.String("gke-release-channel", "", "GKE release channel to be used for cluster deploy. One of 'rapid', 'stable' or 'regular'")
5252
gkeTestClusterPrefix = flag.String("gke-cluster-prefix", "pdcsi", "Prefix of GKE cluster names. A random suffix will be appended to form the full name.")
5353
gkeTestClusterName = flag.String("gke-cluster-name", "", "Name of existing cluster")
@@ -155,7 +155,7 @@ func main() {
155155
if !*bringupCluster && *platform != "windows" {
156156
ensureVariable(kubeFeatureGates, false, "kube-feature-gates set but not bringing up new cluster")
157157
} else {
158-
ensureVariable(imageType, true, "image type is a required flag. Available options include 'cos' and 'ubuntu'")
158+
ensureVariable(imageType, true, "image type is a required flag. A good default is 'cos_containerd'")
159159
if *isRegionalCluster {
160160
klog.Error("is-regional-cluster can only be set when using an existing cluster")
161161
}

test/run-k8s-integration-ci.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ readonly kube_version=${GCE_PD_KUBE_VERSION:-master}
2020
readonly test_version=${TEST_VERSION:-master}
2121
readonly gce_zone=${GCE_CLUSTER_ZONE:-us-central1-b}
2222
readonly gce_region=${GCE_CLUSTER_REGION:-}
23-
readonly image_type=${IMAGE_TYPE:-cos}
23+
readonly image_type=${IMAGE_TYPE:-cos_containerd}
2424
readonly use_gke_managed_driver=${USE_GKE_MANAGED_DRIVER:-false}
2525
readonly gke_release_channel=${GKE_RELEASE_CHANNEL:-""}
2626
readonly teardown_driver=${GCE_PD_TEARDOWN_DRIVER:-true}

test/run-k8s-integration.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ readonly kube_version=${GCE_PD_KUBE_VERSION:-master}
2020
readonly test_version=${TEST_VERSION:-master}
2121
readonly gce_zone=${GCE_CLUSTER_ZONE:-us-central1-b}
2222
readonly gce_region=${GCE_CLUSTER_REGION:-}
23-
readonly image_type=${IMAGE_TYPE:-cos}
23+
readonly image_type=${IMAGE_TYPE:-cos_containerd}
2424
readonly use_gke_managed_driver=${USE_GKE_MANAGED_DRIVER:-false}
2525
readonly gke_release_channel=${GKE_RELEASE_CHANNEL:-""}
2626
readonly teardown_driver=${GCE_PD_TEARDOWN_DRIVER:-true}

0 commit comments

Comments
 (0)