Filter out user errors from GetDisk error returned from ControllerPublishVolume

amacaskill · amacaskill · commit 4cc23f0d6a07 · 2023-06-08T23:22:35.000Z
diff --git a/pkg/gce-pd-csi-driver/controller.go b/pkg/gce-pd-csi-driver/controller.go
@@ -578,7 +578,7 @@ func (gceCS *GCEControllerServer) executeControllerPublishVolume(ctx context.Con
 		if gce.IsGCENotFoundError(err) {
 			return nil, status.Errorf(codes.NotFound, "Could not find disk %v: %v", volKey.String(), err.Error()), diskType
 		}
-		return nil, status.Errorf(codes.Internal, "Failed to getDisk: %v", err.Error()), diskType
+		return nil, common.LoggedError("Failed to getDisk: ", err), diskType
 	}
 	instanceZone, instanceName, err := common.NodeIDToZoneAndName(nodeID)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -578,7 +578,7 @@ func (gceCS *GCEControllerServer) executeControllerPublishVolume(ctx context.Con`
`578`	`578`	`if gce.IsGCENotFoundError(err) {`
`579`	`579`	`return nil, status.Errorf(codes.NotFound, "Could not find disk %v: %v", volKey.String(), err.Error()), diskType`
`580`	`580`	`}`
`581`		`- return nil, status.Errorf(codes.Internal, "Failed to getDisk: %v", err.Error()), diskType`
	`581`	`+ return nil, common.LoggedError("Failed to getDisk: ", err), diskType`
`582`	`582`	`}`
`583`	`583`	`instanceZone, instanceName, err := common.NodeIDToZoneAndName(nodeID)`
`584`	`584`	`if err != nil {`