Skip to content

Commit 2a69c6a

Browse files
authored
Merge pull request #905 from mauriciopoppe/windows-eol
Remove Windows versions 1909 and 2004 which have reached EOL
2 parents e7b7bba + 1e3fd65 commit 2a69c6a

File tree

1 file changed

+4
-18
lines changed

1 file changed

+4
-18
lines changed

Makefile

+4-18
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,11 @@ DRIVERWINDOWSBINARY=${DRIVERBINARY}.exe
2424
DOCKER=DOCKER_CLI_EXPERIMENTAL=enabled docker
2525

2626
BASE_IMAGE_LTSC2019=mcr.microsoft.com/windows/servercore:ltsc2019
27-
BASE_IMAGE_1909=mcr.microsoft.com/windows/servercore:1909
28-
BASE_IMAGE_2004=mcr.microsoft.com/windows/servercore:2004
2927
BASE_IMAGE_20H2=mcr.microsoft.com/windows/servercore:20H2
3028

3129
# Both arrays MUST be index aligned.
32-
WINDOWS_IMAGE_TAGS=ltsc2019 1909 2004 20H2
33-
WINDOWS_BASE_IMAGES=$(BASE_IMAGE_LTSC2019) $(BASE_IMAGE_1909) $(BASE_IMAGE_2004) $(BASE_IMAGE_20H2)
30+
WINDOWS_IMAGE_TAGS=ltsc2019 20H2
31+
WINDOWS_BASE_IMAGES=$(BASE_IMAGE_LTSC2019) $(BASE_IMAGE_20H2)
3432

3533
GCFLAGS=""
3634
ifdef GCE_PD_CSI_DEBUG
@@ -59,26 +57,14 @@ build-and-push-windows-container-ltsc2019: require-GCE_PD_CSI_STAGING_IMAGE init
5957
--build-arg BASE_IMAGE=$(BASE_IMAGE_LTSC2019) \
6058
--build-arg STAGINGVERSION=$(STAGINGVERSION) --push .
6159

62-
build-and-push-windows-container-1909: require-GCE_PD_CSI_STAGING_IMAGE init-buildx
63-
$(DOCKER) buildx build --file=Dockerfile.Windows --platform=windows \
64-
-t $(STAGINGIMAGE):$(STAGINGVERSION)_1909 \
65-
--build-arg BASE_IMAGE=$(BASE_IMAGE_1909) \
66-
--build-arg STAGINGVERSION=$(STAGINGVERSION) --push .
67-
68-
build-and-push-windows-container-2004: require-GCE_PD_CSI_STAGING_IMAGE init-buildx
69-
$(DOCKER) buildx build --file=Dockerfile.Windows --platform=windows \
70-
-t $(STAGINGIMAGE):$(STAGINGVERSION)_2004 \
71-
--build-arg BASE_IMAGE=$(BASE_IMAGE_2004) \
72-
--build-arg STAGINGVERSION=$(STAGINGVERSION) --push .
73-
7460
build-and-push-windows-container-20H2: require-GCE_PD_CSI_STAGING_IMAGE init-buildx
7561
$(DOCKER) buildx build --file=Dockerfile.Windows --platform=windows \
7662
-t $(STAGINGIMAGE):$(STAGINGVERSION)_20H2 \
7763
--build-arg BASE_IMAGE=$(BASE_IMAGE_20H2) \
7864
--build-arg STAGINGVERSION=$(STAGINGVERSION) --push .
7965

80-
build-and-push-multi-arch: build-and-push-container-linux-amd64 build-and-push-container-linux-arm64 build-and-push-windows-container-ltsc2019 build-and-push-windows-container-1909 build-and-push-windows-container-2004 build-and-push-windows-container-20H2
81-
$(DOCKER) manifest create --amend $(STAGINGIMAGE):$(STAGINGVERSION) $(STAGINGIMAGE):$(STAGINGVERSION)_linux_amd64 $(STAGINGIMAGE):$(STAGINGVERSION)_linux_arm64 $(STAGINGIMAGE):$(STAGINGVERSION)_20H2 $(STAGINGIMAGE):$(STAGINGVERSION)_2004 $(STAGINGIMAGE):$(STAGINGVERSION)_1909 $(STAGINGIMAGE):$(STAGINGVERSION)_ltsc2019
66+
build-and-push-multi-arch: build-and-push-container-linux-amd64 build-and-push-container-linux-arm64 build-and-push-windows-container-ltsc2019 build-and-push-windows-container-20H2
67+
$(DOCKER) manifest create --amend $(STAGINGIMAGE):$(STAGINGVERSION) $(STAGINGIMAGE):$(STAGINGVERSION)_linux_amd64 $(STAGINGIMAGE):$(STAGINGVERSION)_linux_arm64 $(STAGINGIMAGE):$(STAGINGVERSION)_20H2 $(STAGINGIMAGE):$(STAGINGVERSION)_ltsc2019
8268
STAGINGIMAGE="$(STAGINGIMAGE)" STAGINGVERSION="$(STAGINGVERSION)" WINDOWS_IMAGE_TAGS="$(WINDOWS_IMAGE_TAGS)" WINDOWS_BASE_IMAGES="$(WINDOWS_BASE_IMAGES)" ./manifest_osversion.sh
8369
$(DOCKER) manifest push -p $(STAGINGIMAGE):$(STAGINGVERSION)
8470

0 commit comments

Comments
 (0)