Skip to content

Commit 16433ea

Browse files
authored
Merge branch 'kubernetes-sigs:master' into hd-mw
2 parents c06aea7 + f299c4d commit 16433ea

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

CHANGELOG/CHANGELOG-1.15.md

+8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
# v1.15.4 - Changelog since v1.15.3
2+
- [release-1.15] [metrics] Fix panic during metrics manager startup by @k8s-infra-cherrypick-robot in https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1898
3+
4+
# v1.15.3 - Changelog since v1.15.2
5+
* [release-1.15] Don't overwrite libc in distroless debian base image by @k8s-infra-cherrypick-robot in https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1884
6+
* [release-1.15] Refactor metric defer() statements to gRPC metric interceptor by @k8s-infra-cherrypick-robot in https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1886
7+
* Automated cherry pick of #1875: Require VACs to use SI units by @travisyx in https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1892
8+
19
# v1.15.2 - Changelog since v1.15.1
210

311
- [release-1.15] Map RESOURCE_OPERATION_RATE_EXCEEDED to ResourceExhausted by @k8s-infra-cherrypick-robot in #1848

deploy/kubernetes/images/prow-stable-sidecar-rc-master/image.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,6 @@ metadata:
4848
imageTag:
4949
name: registry.k8s.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver
5050
newName: gcr.io/k8s-staging-cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver
51-
newTag: "v1.15.3-rc2"
51+
newTag: "v1.15.4-rc1"
5252
---
5353

test/k8s-integration/main.go

+5-9
Original file line numberDiff line numberDiff line change
@@ -688,8 +688,8 @@ func generateGKETestSkip(testParams *testParameters) string {
688688
skipString = skipString + "|should.provision.correct.filesystem.size.when.restoring.snapshot.to.larger.size.pvc"
689689
}
690690

691-
// VolumeAttributesClasses were promoted to beta in 1.31
692-
if curVer.lessThan(mustParseVersion("1.31.0")) {
691+
// VolumeAttributesClasses were promoted to beta in 1.31, but is not supported on managed driver.
692+
if curVer.lessThan(mustParseVersion("1.31.0")) || testParams.useGKEManagedDriver {
693693
skipString = skipString + "|VolumeAttributesClass"
694694
}
695695

@@ -814,13 +814,9 @@ func runTestsWithConfig(testParams *testParameters, testConfigArg, reportPrefix
814814
focuses = append(focuses, "VolumeSnapshotDataSource")
815815
}
816816

817-
// If testParams.volumeAttributesClassFile is empty, then VAC tests will be automatically skipped. Otherwise confirm
818-
// the right tests are run.
819-
if testParams.volumeAttributesClassFile != "" && strings.Contains(skip, "VolumeAttributesClass") {
820-
return fmt.Errorf("VolumeAttributesClass file %s specified, but VolumeAttributesClass tests are skipped: %s", testParams.volumeAttributesClassFile, skip)
821-
}
822-
if testParams.volumeAttributesClassFile != "" {
823-
// If there is a VolumeAttributesClass file, run VAC tests
817+
// testParams.volumeAttributesClassFile is always set, so rely on test skip to determine if VAC tests should
818+
// be run.
819+
if testParams.volumeAttributesClassFile != "" && !strings.Contains(skip, "VolumeAttributesClass") {
824820
focuses = append(focuses, "VolumeAttributesClass")
825821
}
826822

0 commit comments

Comments
 (0)