Skip to content

Commit 1164b8d

Browse files
committed
Update test suite setup
1 parent a6420e8 commit 1164b8d

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

Diff for: test/e2e/tests/setup_e2e_test.go

+17-12
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ var _ = BeforeSuite(func() {
8181
defer close(hdtcc)
8282

8383
zones := strings.Split(*zones, ",")
84-
// Create 2 instances for each zone as we need 2 instances each zone for certain test cases
85-
8684
rand.Seed(time.Now().UnixNano())
8785

8886
computeService, err = remote.GetComputeClient()
@@ -109,20 +107,22 @@ var _ = BeforeSuite(func() {
109107

110108
numberOfInstancesPerZone := 2
111109

112-
setupContext := func(zones []string, randInt int) {
113-
for _, zone := range zones {
114-
go func(curZone string) {
110+
setupContext := func(zone string) {
111+
// Create 2 instances for each zone as we need 2 instances each zone for certain test cases
112+
for j := 0; j < numberOfInstancesPerZone; j++ {
113+
go func(curZone string, randInt int) {
115114
defer GinkgoRecover()
116115
tcc <- NewDefaultTestContext(curZone, strconv.Itoa(randInt))
117-
}(zone)
118-
go func(curZone string) {
119-
defer GinkgoRecover()
120-
hdtcc <- NewTestContext(curZone, *hdMinCpuPlatform, *hdMachineType, strconv.Itoa(randInt))
121-
}(zone)
116+
}(zone, j)
122117
}
118+
go func(curZone string) {
119+
defer GinkgoRecover()
120+
hdtcc <- NewTestContext(curZone, *hdMinCpuPlatform, *hdMachineType, "0")
121+
}(zone)
123122
}
124-
for j := 0; j < numberOfInstancesPerZone; j++ {
125-
setupContext(zones, j)
123+
124+
for _, zone := range zones {
125+
setupContext(zone)
126126
}
127127

128128
for i := 0; i < len(zones)*numberOfInstancesPerZone; i++ {
@@ -178,6 +178,11 @@ func NewTestContext(zone, minCpuPlatform, machineType string, instanceNumber str
178178
ComputeService: computeService,
179179
LocalSSDCount: localSSDCount,
180180
}
181+
182+
if machineType == *hdMachineType {
183+
// Machine type is defaulted to c3-standard-2 which doesn't support LSSD and we don't need LSSD for HdHA test context
184+
instanceConfig.LocalSSDCount = 0
185+
}
181186
i, err := remote.SetupInstance(instanceConfig)
182187
if err != nil {
183188
klog.Fatalf("Failed to setup instance %v: %v", nodeID, err)

Diff for: test/remote/instance.go

-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,6 @@ func (i *InstanceInfo) CreateOrGetInstance(localSSDCount int) error {
148148
EnableConfidentialCompute: true,
149149
}
150150
}
151-
klog.Infof("=======Adding LocalSSD %v=============", localSSDCount)
152151

153152
localSSDConfig := &compute.AttachedDisk{
154153
Type: "SCRATCH",

0 commit comments

Comments
 (0)