Made a no-op windows implementation of the linkcache package

Author: julianKatz

manifest_osversion.sh

@@ -4,7 +4,7 @@ set -o xtrace
 
 # The following is a workaround for issue https://github.com/moby/moby/issues/41417
 # to manually inserver os.version information into docker manifest file
-# TODO: once docker manifest annotation for os.versions is availabler for the installed docker here,
+# TODO: once docker manifest annotation for os.versions is available for the installed docker here,
 # replace the following with annotation approach. https://github.com/docker/cli/pull/2578
 
 export DOCKER_CLI_EXPERIMENTAL=enabled
@@ -14,7 +14,7 @@ IFS=', ' read -r -a imagetags <<< "$WINDOWS_IMAGE_TAGS"
 IFS=', ' read -r -a baseimages <<< "$WINDOWS_BASE_IMAGES"
 MANIFEST_TAG=${STAGINGIMAGE}:${STAGINGVERSION}
 
-# translate from image tag to docker manifest foler format
+# translate from image tag to docker manifest folder format
 # e.g., gcr.io_k8s-staging-csi_gce-pd-windows-v2
 manifest_folder=$(echo "${MANIFEST_TAG}" | sed "s|/|_|g" | sed "s/:/-/")
 echo ${manifest_folder}

pkg/linkcache/cache_test.go

@@ -15,18 +15,6 @@ import (
 
 const byIdDir = "/dev/disk/by-id"
 
-type deviceMapping struct {
-	symlink  string
-	realPath string
-}
-
-type DeviceCache struct {
-	volumes map[string]deviceMapping
-	period  time.Duration
-	// dir is the directory to look for device symlinks
-	dir string
-}
-
 func NewDeviceCacheForNode(ctx context.Context, period time.Duration, nodeName string) (*DeviceCache, error) {
 	node, err := k8sclient.GetNodeWithRetry(ctx, nodeName)
 	if err != nil {

pkg/linkcache/devices.go renamed to pkg/linkcache/devices_linux.go

@@ -0,0 +1,25 @@
+//go:build windows
+
+package linkcache
+
+import (
+	"context"
+	"fmt"
+	"time"
+)
+
+func NewDeviceCacheForNode(ctx context.Context, period time.Duration, nodeName string) (*DeviceCache, error) {
+	return nil, fmt.Errorf("NewDeviceCacheForNode is not implemented for Windows")
+}
+
+func (d *DeviceCache) Run(ctx context.Context) {
+	// Not implemented for Windows
+}
+
+func (d *DeviceCache) AddVolume(volumeID string) error {
+	return fmt.Errorf("AddVolume is not implemented for Windows")
+}
+
+func (d *DeviceCache) RemoveVolume(volumeID string) {
+	// Not implemented for Windows
+}

pkg/linkcache/devices_windows.go

@@ -0,0 +1,15 @@
+package linkcache
+
+import "time"
+
+type deviceMapping struct {
+	symlink  string
+	realPath string
+}
+
+type DeviceCache struct {
+	volumes map[string]deviceMapping
+	period  time.Duration
+	// dir is the directory to look for device symlinks
+	dir string
+}