Skip to content

Docs: Getting Started Guide for istio resulting in a broken example #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aslakknutsen opened this issue Apr 25, 2025 · 4 comments · Fixed by #780
Closed

Docs: Getting Started Guide for istio resulting in a broken example #740

aslakknutsen opened this issue Apr 25, 2025 · 4 comments · Fixed by #780
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@aslakknutsen
Copy link

What happened:
Following the Istio setup in the Getting Started Guide results in a non working setup (istio/istio#56055) as the two code bases have diverged.

What you expected to happen:
A working example.

How to reproduce it (as minimally and precisely as possible):
Using any "older" version of istio will trigger this bug as GIE has moved to not support BUFFERED processing mode.

Anything else we need to know?:

Environment:
*

Maybe some form of "testable docs" could be handy to catch regressions on both sides and as a light sanity check?

@aslakknutsen aslakknutsen added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 25, 2025
@nirrozenbaum
Copy link
Contributor

@aslakknutsen can you add a link to the fix PR you created in Istio?
just to add more context for future readers of this issue.

@nirrozenbaum
Copy link
Contributor

once that PR is merged in Istio, we should make sure Istio has a new tag with the fix and update our getting started guide accordingly.

CC @LiorLieberman @kfswain

@LiorLieberman
Copy link
Member

Thanks! @nirrozenbaum lets keep this open until this is released.

For ref this is the PR that broke it - #672

@LiorLieberman
Copy link
Member

/assign

@kfswain kfswain added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants