Skip to content

InferencePool: Add BBR Config #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danehans opened this issue Apr 18, 2025 · 5 comments
Open

InferencePool: Add BBR Config #711

danehans opened this issue Apr 18, 2025 · 5 comments
Assignees
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@danehans
Copy link
Contributor

danehans commented Apr 18, 2025

Currently, inferencepool.spec inlines EndpointPickerConfig that is defined by the following:

Specifies the configuration needed by the proxy to discover and connect to the endpoint picker service that picks endpoints for the requests routed to this pool.

The Body Based Routing (BBR) extension was recently added, but InferencePool was not updated. Does BBR act independently of an InferencePool? If so, how does a proxy discover and connect with this extension?

@kfswain
Copy link
Collaborator

kfswain commented Apr 18, 2025

Yeah, it should act independently of the InferencePool (as it's not strictly necessary, and useful more for routing via HTTPRoute rules) @rramkumar1 I believe added some documentation for how this should/could be used in OSS. If not we absolutely should have something

@kfswain
Copy link
Collaborator

kfswain commented Apr 18, 2025

Perhaps this convo would tie into: kubernetes-sigs/gateway-api#3625 (comment) (except somewhat different, as it would happen before the HTTPRoute)

@rramkumar1
Copy link
Contributor

rramkumar1 commented Apr 21, 2025

@danehans This won't need any config in the InferencePool, it's deployed separately.

Below is an example of how it would have been deployed using Istio GW (note InferencePool support there is still experimental).

https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/config/charts/body-based-routing/templates/istio.yaml

Other LB implementations would do something similar depending on how they allow ext_proc configuration.

@nirrozenbaum
Copy link
Contributor

@rramkumar1 I went over this chart. overall looks good and very clear.
I just don't see there anything related to EPP which makes sense according to the this response.

it's deployed separately.

do have somewhere a documentation of the full flow using BBR + EPP?
how would one connect BBR to EPP if he wishes to do so?

@rramkumar1
Copy link
Contributor

Sure I'll take an AI to add some more docs on this.

/assign

@kfswain kfswain added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants