Skip to content

EPP should allow configurable metrics collection #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #681
nirrozenbaum opened this issue Apr 17, 2025 · 1 comment
Open
Tracked by #681

EPP should allow configurable metrics collection #703

nirrozenbaum opened this issue Apr 17, 2025 · 1 comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nirrozenbaum
Copy link
Contributor

nirrozenbaum commented Apr 17, 2025

once we add the notion of Filter and Scorer to EPP, I envisage that orgs that use GIE will have their own filters and scorers in some internal repo.
while GIE is not expected to support dynamic changes of filters/scorers, I believe we do want to allow an easy way to setup different filters/scorers in a fork. That is, I expect the filters/scorers to get registered in the code in a single place (e.g., single file), such that others can change their filters/scorers without drifting from upstream.
With that in mind, the main logic in a scorer (and/or filter) is usually based on some metric(s). so basically if one wants to define his own scorer, he might need to define also additional metric(s).
same as I expect that filters/scorers setup can be easily replaced without drifting from upstream, I think we should allow a very easy, simple and straight forward way to define the set of metrics (that eventually filter/scorer will use) that EPP collects.

@nirrozenbaum
Copy link
Contributor Author

seems related to this comment #683 (comment)

@kfswain kfswain mentioned this issue Apr 23, 2025
17 tasks
@kfswain kfswain added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants