Skip to content

Optimize Dockerfile for Multiple Extensions #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danehans opened this issue Apr 15, 2025 · 5 comments
Closed

Optimize Dockerfile for Multiple Extensions #698

danehans opened this issue Apr 15, 2025 · 5 comments
Assignees
@GunaKKIBM
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@danehans
Copy link
Contributor

Currently, the EPP and BBR Dockerfiles copy cmd and pkg directories during an image build:

...
COPY cmd ./cmd
COPY pkg ./pkg
...

Since each above directory now contains EPP and BBR subdirectories, the COPY commands should be updated for each Dockerfile to only include the associated subdirectories.
@danehans danehans added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 15, 2025
@GunaKKIBM
Copy link
Contributor

/assign

@kfswain kfswain added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 24, 2025
@danehans
Copy link
Contributor Author

danehans commented May 5, 2025

@GunaKKIBM thanks for taking on this issue. Do you have an ETA when a PR will be ready for review?

@GunaKKIBM GunaKKIBM mentioned this issue May 9, 2025
Merged
@GunaKKIBM
Copy link
Contributor

@danehans
Apologies for the delay
#811 - I have raised a PR, please take a look

@GunaKKIBM
Copy link
Contributor

GunaKKIBM commented May 10, 2025 •
edited
Loading

As the above mentioned PR got merged, please close the issue, as I do not have the permissions to do so.

@danehans
Copy link
Contributor Author

@GunaKKIBM thanks for the PR! In the future, you can add "Fixes: #<ISSUE_NUMBER>" on a dedicated line in your PR's description, and the issue will automatically close when your PR merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GunaKKIBM GunaKKIBM

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danehans @GunaKKIBM @kfswain