Skip to content

lora-syncer should block on startup until the server is ready #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahg-g opened this issue Mar 28, 2025 · 1 comment
Closed

lora-syncer should block on startup until the server is ready #597

ahg-g opened this issue Mar 28, 2025 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Mar 28, 2025

What would you like to be added:

lora-syncer should block on startup until the server is ready

Why is this needed:

otherwise it will not properly sync on startup and will have to wait until an update to the configmap happen to trigger updating the models.

/kind bug
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 28, 2025
@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 28, 2025

Fixed with #605

@kfswain kfswain closed this as completed Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k8s-ci-robot @ahg-g @kfswain