Skip to content

Improve vLLM upstream health checks to only pass when models are servable #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarterclayton opened this issue Mar 21, 2025 · 1 comment
Closed

Improve vLLM upstream health checks to only pass when models are servable #558

smarterclayton opened this issue Mar 21, 2025 · 1 comment

Comments

@smarterclayton
Copy link
Contributor

smarterclayton commented Mar 21, 2025 •
edited
Loading

As documented in #550, the default vLLM configuration could be improved and documented better. A startupProbe on /health is the right default for vLLM given it does not load the server until a very long model load is complete, but tunables may vary.
@smarterclayton smarterclayton mentioned this issue Mar 21, 2025
Merged
@kfswain
Copy link
Collaborator

kfswain commented Apr 22, 2025

I believe #550 actually resolved this:

gateway-api-inference-extension/config/manifests/vllm/gpu-deployment.yaml

Line 137 in c546506

# vLLM does not start the OpenAI server (and hence make /health available)

@kfswain kfswain closed this as completed Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smarterclayton @kfswain