Skip to content

e2e Tests Fail to Validate e2e Functionality #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danehans opened this issue Jan 28, 2025 · 0 comments · Fixed by #241
Closed

e2e Tests Fail to Validate e2e Functionality #239

danehans opened this issue Jan 28, 2025 · 0 comments · Fixed by #241
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@danehans
Copy link
Contributor

#217 introdduced an initial e2e test. However, the test does not properly validate e2e functionality:

$ make test-e2e
...
Ran 1 of 1 Specs in 250.096 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAPIs (250.10s)
PASS
ok  	inference.networking.x-k8s.io/gateway-api-inference-extension/test/e2e	250.122s

Manually testing indicates otherwise:

$ kubectl get svc/envoy
NAME    TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)    AGE
envoy   ClusterIP   10.96.233.11   <none>        8081/TCP   5m1s
$ IP=10.96.233.11
$ PORT=8081
$ kubectl exec po/curl -- curl -i $IP:$PORT/v1/completions -H 'Content-Type: application/json' -d '{"model": "tweet-summary","prompt": "Write as if you were a critic: San Francisco","max_tokens": 100,"temperature": 0}'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0HTTP/1.1 500 Internal Server Error
100   118    0     0  100   118      0  60793 --:--:-- --:--:-- --:--:--  115k
date: Tue, 28 Jan 2025 20:58:55 GMT
connection: close
content-length: 0

The envoy manifest used for testing is misconfigured and the curl command needs to be inspected for a possible bug.

@danehans danehans added the kind/bug Categorizes issue or PR as related to a bug. label Jan 28, 2025
@danehans danehans self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant