Skip to content

Failed to run the examples under pkg/README.md #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jeffwan opened this issue Dec 29, 2024 · 1 comment · Fixed by #139
Closed

Failed to run the examples under pkg/README.md #135

Jeffwan opened this issue Dec 29, 2024 · 1 comment · Fixed by #139

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Dec 29, 2024

We've identified a few issues where the tutorials are out of sync with the current system implementation.

  1. unknown fields are being used in examples
    image

  2. instance-gateway has not been updated to latest gateway names
    image

  3. The model definition in InferenceModel and the example request do not match
    image
    image

  4. lack of enough reference on dependencies like envoy gateway installation and hf-token secret setup.
    image

Note: config error due to missing HF token
@Jeffwan Jeffwan mentioned this issue Dec 29, 2024
Merged
@yankay yankay mentioned this issue Dec 31, 2024
Merged
@ahg-g
Copy link
Contributor

ahg-g commented Jan 1, 2025

With #139 merging, can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Jeffwan @ahg-g