Skip to content

Commit e71fd92

Browse files
authored
removed double loop on docs in hermetic test (#668)
use unstructured instead of checking InferenceModel/InferencePool and unmarshalling to specific object Signed-off-by: Nir Rozenbaum <[email protected]>
1 parent 3690dbe commit e71fd92

File tree

1 file changed

+6
-19
lines changed

1 file changed

+6
-19
lines changed

test/integration/epp/hermetic_test.go

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ import (
4444
"google.golang.org/protobuf/testing/protocmp"
4545
"google.golang.org/protobuf/types/known/structpb"
4646
corev1 "k8s.io/api/core/v1"
47+
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
4748
"k8s.io/apimachinery/pkg/fields"
4849
"k8s.io/apimachinery/pkg/runtime"
4950
"k8s.io/apimachinery/pkg/types"
@@ -1691,27 +1692,13 @@ func BeforeSuite() func() {
16911692
}
16921693

16931694
for _, doc := range docs {
1694-
inferenceModel := &v1alpha2.InferenceModel{}
1695-
if err = yaml.Unmarshal(doc, inferenceModel); err != nil {
1695+
obj := &unstructured.Unstructured{}
1696+
if err = yaml.Unmarshal(doc, obj); err != nil {
16961697
logutil.Fatal(logger, err, "Can't unmarshal object", "document", doc)
16971698
}
1698-
if inferenceModel.Kind == "InferenceModel" {
1699-
logger.Info("Creating inference model", "model", inferenceModel)
1700-
if err := k8sClient.Create(context.Background(), inferenceModel); err != nil {
1701-
logutil.Fatal(logger, err, "Unable to create inferenceModel", "modelName", inferenceModel.Name)
1702-
}
1703-
}
1704-
}
1705-
for _, doc := range docs {
1706-
inferencePool := &v1alpha2.InferencePool{}
1707-
if err = yaml.Unmarshal(doc, inferencePool); err != nil {
1708-
logutil.Fatal(logger, err, "Can't unmarshal object", "document", doc)
1709-
}
1710-
if inferencePool.Kind == "InferencePool" {
1711-
logger.Info("Creating inference pool", "pool", inferencePool)
1712-
if err := k8sClient.Create(context.Background(), inferencePool); err != nil {
1713-
logutil.Fatal(logger, err, "Unable to create inferencePool", "poolName", inferencePool.Name)
1714-
}
1699+
logger.Info("Creating object", "kind", obj.GetKind(), "object", obj)
1700+
if err := k8sClient.Create(context.Background(), obj); err != nil {
1701+
logutil.Fatal(logger, err, "Unable to create object", "object", obj.GetName())
17151702
}
17161703
}
17171704

0 commit comments

Comments
 (0)