Skip to content

Commit cfafbca

Browse files
committed
Adding terminationGracePeriodSeconds to match vLLMs
1 parent 4ff391b commit cfafbca

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

config/charts/inferencepool/templates/epp-deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ spec:
1616
{{- include "gateway-api-inference-extension.selectorLabels" . | nindent 8 }}
1717
spec:
1818
serviceAccountName: {{ include "gateway-api-inference-extension.name" . }}
19+
# Conservatively, this timeout should mirror the longest grace period of the pods within the pool
20+
terminationGracePeriodSeconds: 130
1921
containers:
2022
- name: epp
2123
image: {{ .Values.inferenceExtension.image.hub }}/{{ .Values.inferenceExtension.image.name }}:{{ .Values.inferenceExtension.image.tag }}

config/manifests/inferencepool-resources.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ spec:
4242
labels:
4343
app: vllm-llama3-8b-instruct-epp
4444
spec:
45+
# Conservatively, this timeout should mirror the longest grace period of the pods within the pool
46+
terminationGracePeriodSeconds: 130
4547
containers:
4648
- name: epp
4749
image: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:main

0 commit comments

Comments
 (0)