ObjRef name update

Author: kfswain

api/v1alpha1/inferencemodel_types.go

@@ -66,12 +66,12 @@ type InferenceModelSpec struct {
 	// Reference to the poolIt must exist in the same namespace.
 	//
 	// +kubebuilder:validation:Required
-	PoolRef *LocalObjectReference `json:"poolRef,omitempty"`
+	PoolRef *PoolObjectReference `json:"poolRef,omitempty"`
 }
 
-// LocalObjectReference identifies an API object within the namespace of the
+// PoolObjectReference identifies an API object within the namespace of the
 // referrer.
-type LocalObjectReference struct {
+type PoolObjectReference struct {
 	// Group is the group of the referent.
 	//
 	// +optional
@@ -93,6 +93,7 @@ type LocalObjectReference struct {
 	//
 	// +kubebuilder:validation:MinLength=1
 	// +kubebuilder:validation:MaxLength=253
+	// +kubebuilder:validation:Required
 	Name string `json:"name,omitempty"`
 }
 

pkg/ext-proc/backend/inferencemodel_reconciler_test.go

@@ -12,7 +12,7 @@ var (
 	service1 = &v1alpha1.InferenceModel{
 		Spec: v1alpha1.InferenceModelSpec{
 			ModelName: "fake model1",
-			PoolRef:   &v1alpha1.LocalObjectReference{Name: "test-pool"},
+			PoolRef:   &v1alpha1.PoolObjectReference{Name: "test-pool"},
 		},
 		ObjectMeta: metav1.ObjectMeta{
 			Name: "test-service",
@@ -21,7 +21,7 @@ var (
 	service1Modified = &v1alpha1.InferenceModel{
 		Spec: v1alpha1.InferenceModelSpec{
 			ModelName: "fake model1",
-			PoolRef:   &v1alpha1.LocalObjectReference{Name: "test-poolio"},
+			PoolRef:   &v1alpha1.PoolObjectReference{Name: "test-poolio"},
 		},
 		ObjectMeta: metav1.ObjectMeta{
 			Name: "test-service",
@@ -30,7 +30,7 @@ var (
 	service2 = &v1alpha1.InferenceModel{
 		Spec: v1alpha1.InferenceModelSpec{
 			ModelName: "fake model",
-			PoolRef:   &v1alpha1.LocalObjectReference{Name: "test-pool"},
+			PoolRef:   &v1alpha1.PoolObjectReference{Name: "test-pool"},
 		},
 		ObjectMeta: metav1.ObjectMeta{
 			Name: "test-service-2",
@@ -96,7 +96,7 @@ func TestUpdateDatastore_InferenceModelReconciler(t *testing.T) {
 			incomingService: &v1alpha1.InferenceModel{
 				Spec: v1alpha1.InferenceModelSpec{
 					ModelName: "fake model",
-					PoolRef:   &v1alpha1.LocalObjectReference{Name: "test-poolio"},
+					PoolRef:   &v1alpha1.PoolObjectReference{Name: "test-poolio"},
 				},
 				ObjectMeta: metav1.ObjectMeta{
 					Name: "unrelated-service",