Add config validation

Signed-off-by: Kunjan Patel <[email protected]>

Author: coolkp

examples/dynamic-lora-sidecar/sidecar/sidecar.py

@@ -1,6 +1,7 @@
 import requests
 import yaml
 import time
+from jsonschema import validate
 from watchfiles import awatch
 import ipaddress
 from dataclasses import dataclass
@@ -43,16 +44,30 @@ class LoraReconciler:
     Reconciles adapters registered on vllm server with adapters listed in configmap in current state
     """
 
-    def __init__(self):
+    def __init__(self, config_validation=True):
         self.health_check_timeout = datetime.timedelta(seconds=300)
         self.health_check_interval = datetime.timedelta(seconds=15)
-
+        self.config_validation = config_validation
+        
+    def validate_config(self, c)-> bool:
+        try:
+            with open('validation.yaml', 'r') as f:
+                schema = yaml.safe_load(f)
+                validate(instance=c, schema=schema)
+                return True
+        except Exception as e:
+            logging.error(f"Cannot load config {CONFIG_MAP_FILE} validation error: {e}")
+            return False
+        
     @property
     def config(self):
         """Load configmap into memory"""
         try:
+            
             with open(CONFIG_MAP_FILE, "r") as f:
                 c = yaml.safe_load(f)
+                if self.config_validation and not self.validate_config(c):
+                    return {}
                 if c is None:
                     c = {}
                 c = c.get("vLLMLoRAConfig",{})

examples/dynamic-lora-sidecar/sidecar/test_sidecar.py

@@ -101,7 +101,7 @@ def setUp(self, mock_get, mock_file):
             mock_response = getMockResponse()
             mock_response.json.return_value = RESPONSES["v1/models"]
             mock_get.return_value = mock_response
-            self.reconciler = LoraReconciler()
+            self.reconciler = LoraReconciler(False)
             self.maxDiff = None
 
     @patch("sidecar.requests.get")

examples/dynamic-lora-sidecar/sidecar/validation.yaml

@@ -0,0 +1,72 @@
+title: vLLMLoRAConfig
+description: Configuration for vLLM LoRA adapters
+type: object
+properties:
+  vLLMLoRAConfig:
+    type: object
+    properties:
+      host:
+        type: string
+        description: Model server's host
+        default: localhost
+      port:
+        type: integer
+        description: Model server's port
+        default: 8000
+      name:
+        type: string
+        description: Name of this config
+      ensureExist:
+        type: object
+        description: List of models to ensure existence on specified model server
+        properties:
+          models:
+            type: array
+            description: List of LoRA adapter configurations
+            items:
+              type: object
+              properties:
+                base_model:
+                  type: string
+                  description: Base model for LoRA adapter
+                id:
+                  type: string
+                  description: Unique ID of LoRA adapter
+                source:
+                  type: string
+                  description: Path (remote or local) to LoRA adapter
+              required:
+                - id
+                - source
+        required:
+          - models
+      ensureNotExist:
+        type: object
+        description: List of models to ensure non-existence on specified model server
+        properties:
+          models:
+            type: array
+            description: List of LoRA adapter configurations
+            items:
+              type: object
+              properties:
+                base_model:
+                  type: string
+                  description: Base model for LoRA adapter
+                id:
+                  type: string
+                  description: Unique ID of LoRA adapter
+                source:
+                  type: string
+                  description: Path (remote or local) to LoRA adapter
+              required:
+                - id
+                - source
+        required:
+          - models
+    required:
+      - host
+      - port
+      - name
+required:
+  - vLLMLoRAConfig