add test for env parser

Author: kaushikmitr

pkg/epp/scheduling/filter_test.go

@@ -430,8 +430,6 @@ func TestFilterFunc(t *testing.T) {
 	}
 }
 
-
-
 // TestLoRASoftAffinityDistribution tests that the loRASoftAffinityFilter function
 // properly distributes requests according to the loraAffinityThreshold
 func TestLoRASoftAffinityDistribution(t *testing.T) {
@@ -456,7 +454,6 @@ func TestLoRASoftAffinityDistribution(t *testing.T) {
 		config.LoraAffinityThreshold = originalThreshold
 	}()
 
-
 	// Create a test request and pods
 	req := &LLMRequest{
 		Model:               testAffinityModel,

pkg/epp/scheduling/scheduler.go

@@ -26,9 +26,9 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log"
 	backendmetrics "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/backend/metrics"
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/datastore"
+	envutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/env"
 	errutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/error"
 	logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/logging"
-	envutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/env"
 )
 
 // Config holds all the configuration values for the scheduler
@@ -130,8 +130,6 @@ var (
 	}
 )
 
-
-
 func NewScheduler(datastore datastore.Datastore) *Scheduler {
 	return &Scheduler{
 		datastore: datastore,
@@ -150,7 +148,7 @@ func (s *Scheduler) Schedule(ctx context.Context, req *LLMRequest) (targetPod ba
 
 	podMetrics := s.datastore.PodGetAll()
 	logger.V(logutil.DEBUG).Info(fmt.Sprintf("Scheduling a request. Metrics: %+v", podMetrics))
-  
+
 	pods, err := s.filter.Filter(logger, req, podMetrics)
 	if err != nil || len(pods) == 0 {
 		return nil, fmt.Errorf("failed to apply filter, resulted %v pods, this should never happen: %w", len(pods), err)

pkg/epp/util/env/env_test.go

@@ -0,0 +1,144 @@
+package env
+
+import (
+	"os"
+	"testing"
+
+	"github.com/go-logr/logr/testr"
+	logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/logging"
+)
+
+func TestGetEnvFloat(t *testing.T) {
+	logger := testr.New(t)
+
+	tests := []struct {
+		name       string
+		key        string
+		value      string
+		defaultVal float64
+		expected   float64
+		setup      func()
+		teardown   func()
+	}{
+		{
+			name:       "env variable exists and is valid",
+			key:        "TEST_FLOAT",
+			value:      "123.456",
+			defaultVal: 0.0,
+			expected:   123.456,
+			setup: func() {
+				os.Setenv("TEST_FLOAT", "123.456")
+			},
+			teardown: func() {
+				os.Unsetenv("TEST_FLOAT")
+			},
+		},
+		{
+			name:       "env variable exists but is invalid",
+			key:        "TEST_FLOAT",
+			value:      "invalid",
+			defaultVal: 99.9,
+			expected:   99.9,
+			setup: func() {
+				os.Setenv("TEST_FLOAT", "invalid")
+			},
+			teardown: func() {
+				os.Unsetenv("TEST_FLOAT")
+			},
+		},
+		{
+			name:       "env variable does not exist",
+			key:        "TEST_FLOAT_MISSING",
+			defaultVal: 42.42,
+			expected:   42.42,
+			setup:      func() {},
+			teardown:   func() {},
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			tc.setup()
+			defer tc.teardown()
+
+			result := GetEnvFloat(tc.key, tc.defaultVal, logger.V(logutil.VERBOSE))
+			if result != tc.expected {
+				t.Errorf("GetEnvFloat(%s, %f) = %f, expected %f", tc.key, tc.defaultVal, result, tc.expected)
+			}
+		})
+	}
+}
+
+func TestGetEnvInt(t *testing.T) {
+	logger := testr.New(t)
+
+	tests := []struct {
+		name       string
+		key        string
+		value      string
+		defaultVal int
+		expected   int
+		setup      func()
+		teardown   func()
+	}{
+		{
+			name:       "env variable exists and is valid",
+			key:        "TEST_INT",
+			value:      "123",
+			defaultVal: 0,
+			expected:   123,
+			setup: func() {
+				os.Setenv("TEST_INT", "123")
+			},
+			teardown: func() {
+				os.Unsetenv("TEST_INT")
+			},
+		},
+		{
+			name:       "env variable exists but is invalid",
+			key:        "TEST_INT",
+			value:      "invalid",
+			defaultVal: 99,
+			expected:   99,
+			setup: func() {
+				os.Setenv("TEST_INT", "invalid")
+			},
+			teardown: func() {
+				os.Unsetenv("TEST_INT")
+			},
+		},
+		{
+			name:       "env variable does not exist",
+			key:        "TEST_INT_MISSING",
+			defaultVal: 42,
+			expected:   42,
+			setup:      func() {},
+			teardown:   func() {},
+		},
+		{
+			name:       "env variable is empty string",
+			key:        "TEST_INT_EMPTY",
+			value:      "",
+			defaultVal: 77,
+			expected:   77,
+			setup: func() {
+				os.Setenv("TEST_INT_EMPTY", "")
+			},
+			teardown: func() {
+				os.Unsetenv("TEST_INT_EMPTY")
+			},
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			tc.setup()
+			defer tc.teardown()
+
+			result := GetEnvInt(tc.key, tc.defaultVal, logger.V(logutil.VERBOSE))
+			if result != tc.expected {
+				t.Errorf("GetEnvInt(%s, %d) = %d, expected %d", tc.key, tc.defaultVal, result, tc.expected)
+			}
+		})
+	}
+}