nil checking short circuit

kfswain · kfswain · commit 9f6199769870 · 2025-02-13T15:26:00.000Z
diff --git a/pkg/ext-proc/backend/inferencepool_reconciler.go b/pkg/ext-proc/backend/inferencepool_reconciler.go
@@ -35,7 +35,7 @@ func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 		klog.Error(err, "unable to get InferencePool")
 		return ctrl.Result{}, err
 	}
-	if !reflect.DeepEqual(serverPool.Spec.Selector, c.Datastore.inferencePool.Spec.Selector) {
+	if c.Datastore.inferencePool == nil || !reflect.DeepEqual(serverPool.Spec.Selector, c.Datastore.inferencePool.Spec.Selector) {
 		c.Datastore.flushPodsAndRefetch(ctx, c.Client, serverPool)
 	}
 	c.updateDatastore(serverPool)

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Reques`
`35`	`35`	`klog.Error(err, "unable to get InferencePool")`
`36`	`36`	`return ctrl.Result{}, err`
`37`	`37`	`}`
`38`		`- if !reflect.DeepEqual(serverPool.Spec.Selector, c.Datastore.inferencePool.Spec.Selector) {`
	`38`	`+ if c.Datastore.inferencePool == nil \|\| !reflect.DeepEqual(serverPool.Spec.Selector, c.Datastore.inferencePool.Spec.Selector) {`
`39`	`39`	`c.Datastore.flushPodsAndRefetch(ctx, c.Client, serverPool)`
`40`	`40`	`}`
`41`	`41`	`c.updateDatastore(serverPool)`