scrubbing serviceName & zone as they are obsolete

Author: kfswain

pkg/ext-proc/backend/inferencepool_reconciler.go

@@ -21,7 +21,6 @@ type InferencePoolReconciler struct {
 	Record             record.EventRecorder
 	PoolNamespacedName types.NamespacedName
 	Datastore          *K8sDatastore
-	Zone               string
 }
 
 func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {

pkg/ext-proc/backend/pod_reconciler.go

@@ -25,7 +25,7 @@ type PodReconciler struct {
 func (c *PodReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
 	inferencePool, err := c.Datastore.getInferencePool()
 	if err != nil {
-		klog.V(logutil.DEFAULT).Infof("Skipping reconciling EndpointSlice because the InferencePool is not available yet: %v", err)
+		klog.V(logutil.DEFAULT).Infof("Skipping reconciling Pod because the InferencePool is not available yet: %v", err)
 		return ctrl.Result{Requeue: true, RequeueAfter: time.Second}, nil
 	}
 

pkg/ext-proc/main.go

@@ -53,14 +53,6 @@ var (
 		"poolNamespace",
 		runserver.DefaultPoolNamespace,
 		"Namespace of the InferencePool this Endpoint Picker is associated with.")
-	serviceName = flag.String(
-		"serviceName",
-		runserver.DefaultServiceName,
-		"Name of the Service that will be used to read EndpointSlices from")
-	zone = flag.String(
-		"zone",
-		runserver.DefaultZone,
-		"The zone that this instance is created in. Will be passed to the corresponding endpointSlice. ")
 	refreshPodsInterval = flag.Duration(
 		"refreshPodsInterval",
 		runserver.DefaultRefreshPodsInterval,
@@ -110,8 +102,6 @@ func main() {
 		TargetEndpointKey:                *targetEndpointKey,
 		PoolName:                         *poolName,
 		PoolNamespace:                    *poolNamespace,
-		ServiceName:                      *serviceName,
-		Zone:                             *zone,
 		RefreshPodsInterval:              *refreshPodsInterval,
 		RefreshMetricsInterval:           *refreshMetricsInterval,
 		RefreshPrometheusMetricsInterval: *refreshPrometheusMetricsInterval,
@@ -221,9 +211,5 @@ func validateFlags() error {
 		return fmt.Errorf("required %q flag not set", "poolName")
 	}
 
-	if *serviceName == "" {
-		return fmt.Errorf("required %q flag not set", "serviceName")
-	}
-
 	return nil
 }

pkg/ext-proc/server/runserver.go

@@ -23,8 +23,6 @@ type ExtProcServerRunner struct {
 	TargetEndpointKey                string
 	PoolName                         string
 	PoolNamespace                    string
-	ServiceName                      string
-	Zone                             string
 	RefreshPodsInterval              time.Duration
 	RefreshMetricsInterval           time.Duration
 	RefreshPrometheusMetricsInterval time.Duration
@@ -40,8 +38,6 @@ const (
 	DefaultTargetEndpointKey                = "x-gateway-destination-endpoint" // default for --targetEndpointKey
 	DefaultPoolName                         = ""                               // required but no default
 	DefaultPoolNamespace                    = "default"                        // default for --poolNamespace
-	DefaultServiceName                      = ""                               // required but no default
-	DefaultZone                             = ""                               // default for --zone
 	DefaultRefreshPodsInterval              = 10 * time.Second                 // default for --refreshPodsInterval
 	DefaultRefreshMetricsInterval           = 50 * time.Millisecond            // default for --refreshMetricsInterval
 	DefaultRefreshPrometheusMetricsInterval = 5 * time.Second                  // default for --refreshPrometheusMetricsInterval
@@ -53,8 +49,6 @@ func NewDefaultExtProcServerRunner() *ExtProcServerRunner {
 		TargetEndpointKey:                DefaultTargetEndpointKey,
 		PoolName:                         DefaultPoolName,
 		PoolNamespace:                    DefaultPoolNamespace,
-		ServiceName:                      DefaultServiceName,
-		Zone:                             DefaultZone,
 		RefreshPodsInterval:              DefaultRefreshPodsInterval,
 		RefreshMetricsInterval:           DefaultRefreshMetricsInterval,
 		RefreshPrometheusMetricsInterval: DefaultRefreshPrometheusMetricsInterval,

pkg/manifests/ext_proc.yaml

@@ -77,8 +77,6 @@ spec:
         - "vllm-llama2-7b-pool"
         - -v
         - "3"
-        - -serviceName
-        - "vllm-llama2-7b-pool"
         - -grpcPort
         - "9002"
         - -grpcHealthPort