Skip to content

Commit 828348d

Browse files
committed
Add screenshots
Signed-off-by: Kunjan Patel <[email protected]>
1 parent c8d9c10 commit 828348d

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

examples/dynamic-lora-sidecar/README.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,9 @@ The sidecar uses the vLLM server's API to load or unload adapters based on the c
4343
```
4444
Do not use subPath, since configmap updates are not reflected in the file
4545

46-
[deployment]: deployment.yaml
46+
[deployment]: deployment.yaml
47+
48+
## Screenshots
49+
![lora-adapter-syncer](screenshots/lora-syncer-sidecar.png)
50+
![config map change](screenshots/configmap-change.png)
51+
![vllm-logs](screenshots/vllm-logs.png)
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
aiohttp==3.10.10
22
pyyaml==6.0.2
33
requests==2.32.3
4-
watchdog==5.0.3
54
watchfiles==0.24.0

examples/dynamic-lora-sidecar/sidecar/sidecar.py

-2
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ def config(self):
5555
if c is None:
5656
c = {}
5757
c = c.get("vLLMLoRAConfig",{})
58-
config_name = c.get("name","")
59-
logging.info(f"loaded vLLMLoRAConfig {config_name} from {CONFIG_MAP_FILE}")
6058
return c
6159
except Exception as e:
6260
logging.error(f"cannot load config {CONFIG_MAP_FILE} {e}")

0 commit comments

Comments
 (0)