Skip to content

Commit 5bf4450

Browse files
committed
Code updates after API type changes
1 parent 3d0c947 commit 5bf4450

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

pkg/epp/controller/inferencemodel_reconciler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func (c *InferenceModelReconciler) Reconcile(ctx context.Context, req ctrl.Reque
5858
notFound = true
5959
}
6060

61-
if notFound || !infModel.DeletionTimestamp.IsZero() || infModel.Spec.PoolRef.Name != c.PoolNamespacedName.Name {
61+
if notFound || !infModel.DeletionTimestamp.IsZero() || infModel.Spec.PoolRef.Name != v1alpha2.ObjectName(c.PoolNamespacedName.Name) {
6262
// InferenceModel object got deleted or changed the referenced pool.
6363
err := c.handleModelDeleted(ctx, req.NamespacedName)
6464
return ctrl.Result{}, err
@@ -128,5 +128,5 @@ func (c *InferenceModelReconciler) SetupWithManager(ctx context.Context, mgr ctr
128128
}
129129

130130
func (c *InferenceModelReconciler) eventPredicate(infModel *v1alpha2.InferenceModel) bool {
131-
return (infModel.Spec.PoolRef.Name == c.PoolNamespacedName.Name) && (infModel.GetNamespace() == c.PoolNamespacedName.Namespace)
131+
return (infModel.Spec.PoolRef.Name == v1alpha2.ObjectName(c.PoolNamespacedName.Name)) && (infModel.GetNamespace() == c.PoolNamespacedName.Namespace)
132132
}

pkg/epp/datastore/datastore.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ func (ds *datastore) ModelResync(ctx context.Context, c client.Client, modelName
184184
for i := range models.Items {
185185
m := &models.Items[i]
186186
if m.Spec.ModelName != modelName || // The index should filter those out, but just in case!
187-
m.Spec.PoolRef.Name != ds.pool.Name || // We don't care about other pools, we could setup an index on this too!
187+
m.Spec.PoolRef.Name != v1alpha2.ObjectName(ds.pool.Name) || // We don't care about other pools, we could setup an index on this too!
188188
!m.DeletionTimestamp.IsZero() { // ignore objects marked for deletion
189189
continue
190190
}

pkg/epp/util/testing/wrappers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ func (m *InferenceModelWrapper) ModelName(modelName string) *InferenceModelWrapp
110110
}
111111

112112
func (m *InferenceModelWrapper) PoolName(poolName string) *InferenceModelWrapper {
113-
m.Spec.PoolRef = v1alpha2.PoolObjectReference{Name: poolName}
113+
m.Spec.PoolRef = v1alpha2.PoolObjectReference{Name: v1alpha2.ObjectName(poolName)}
114114
return m
115115
}
116116

test/utils/wrappers.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ func (m *InferenceModelWrapper) SetCriticality(level v1alpha2.Criticality) *Infe
5858
// for group/kind and name as the PoolObjectReference name.
5959
func (m *InferenceModelWrapper) SetPoolRef(name string) *InferenceModelWrapper {
6060
ref := v1alpha2.PoolObjectReference{
61-
Group: v1alpha2.GroupVersion.Group,
61+
Group: v1alpha2.Group(v1alpha2.GroupVersion.Group),
6262
Kind: "inferencepools",
63-
Name: name,
63+
Name: v1alpha2.ObjectName(name),
6464
}
6565
m.Spec.PoolRef = ref
6666
return m

0 commit comments

Comments
 (0)