candita feedback

Author: kfswain

api/inferencemodel_types.go

@@ -144,7 +144,7 @@ const (
 // to exist at request time, the error is processed by the Inference Gateway
 // and emitted on the appropriate InferenceModel object.
 type TargetModel struct {
-	// Name is the name of the adapter as expected by the ModelServer.
+	// Name is the name of the adapter or base model, as expected by the ModelServer.
 	//
 	// +kubebuilder:validation:MaxLength=253
 	// +kubebuilder:validation:Required
@@ -174,10 +174,31 @@ type TargetModel struct {
 
 // InferenceModelStatus defines the observed state of InferenceModel
 type InferenceModelStatus struct {
-	// Conditions track the state of the InferencePool.
+	// Conditions track the state of the InferenceModel.
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 }
 
+// InferenceModelConditionType is a type of condition for the InferenceModel.
+type InferenceModelConditionType string
+
+// InferenceModelConditionReason is the reason for a given InferenceModelConditionType.
+type InferenceModelConditionReason string
+
+const (
+	// This condition indicates whether the model is ready for traffic or not, and why.
+	ModelConditionReady InferenceModelConditionType = "Ready"
+
+	// Desired state. Model is ready for serving with no conflicts or issues.
+	ModelReasonReady InferenceModelConditionReason = "Ready"
+
+	// This reason is used when a given ModelName already exists within the pool.
+	// Details about naming conflict resolution are on the ModelName field itself.
+	ModelReasonNameInUse InferenceModelConditionReason = "ModelNameInUse"
+
+	// This reason is the initial state, and indicates that the controller has not yet reconciled the InferenceModel.
+	PoolReasonPending InferenceModelConditionReason = "Pending"
+)
+
 func init() {
 	SchemeBuilder.Register(&InferenceModel{}, &InferenceModelList{})
 }

api/inferencepool_types.go

@@ -91,6 +91,7 @@ type LabelKey string
 // * must be 63 characters or less (can be empty),
 // * unless empty, must begin and end with an alphanumeric character ([a-z0-9A-Z]),
 // * could contain dashes (-), underscores (_), dots (.), and alphanumerics between.
+// Labels are case sensitive, so: my-label and My-Label are considered distinct.
 //
 // Valid values include:
 //
@@ -109,6 +110,26 @@ type InferencePoolStatus struct {
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 }
 
+// InferencePoolConditionType is a type of condition for the InferencePool
+type InferencePoolConditionType string
+
+// InferencePoolConditionReason is the reason for a given InferencePoolConditionType
+type InferencePoolConditionReason string
+
+const (
+	// This condition indicates whether the pool is ready for traffic or not, and why.
+	PoolConditionReady InferencePoolConditionType = "Ready"
+
+	// Desired state. The pool and its components are initialized and ready for traffic.
+	PoolReasonReady InferencePoolConditionReason = "Ready"
+
+	// This reason is used when the EPP has not yet passed health checks, or has started failing them.
+	PoolReasonEPPNotHealthy InferencePoolConditionReason = "EndpointPickerNotHealthy"
+
+	// This reason is the initial state, and indicates that the controller has not yet reconciled this pool.
+	PoolReasonPending InferencePoolConditionReason = "Pending"
+)
+
 func init() {
 	SchemeBuilder.Register(&InferencePool{}, &InferencePoolList{})
 }