Skip to content

Commit 3dee812

Browse files
committed
bug fix
Signed-off-by: Kuromesi <[email protected]>
1 parent 0789e84 commit 3dee812

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

pkg/epp/backend/provider.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,11 @@ func (p *Provider) Init(ctx context.Context, refreshMetricsInterval, refreshProm
105105

106106
func (p *Provider) refreshMetricsOnce(logger logr.Logger) error {
107107
loggerTrace := logger.V(logutil.TRACE)
108+
pool, _ := p.datastore.PoolGet()
109+
if pool == nil {
110+
loggerTrace.Info("No inference pool or not initialized")
111+
return nil
112+
}
108113
ctx, cancel := context.WithTimeout(context.Background(), fetchMetricsTimeout)
109114
defer cancel()
110115
start := time.Now()
@@ -113,6 +118,7 @@ func (p *Provider) refreshMetricsOnce(logger logr.Logger) error {
113118
// TODO: add a metric instead of logging
114119
loggerTrace.Info("Metrics refreshed", "duration", d)
115120
}()
121+
116122
var wg sync.WaitGroup
117123
errCh := make(chan error)
118124
processOnePod := func(key, value any) bool {
@@ -121,7 +127,6 @@ func (p *Provider) refreshMetricsOnce(logger logr.Logger) error {
121127
wg.Add(1)
122128
go func() {
123129
defer wg.Done()
124-
pool, _ := p.datastore.PoolGet()
125130
updated, err := p.pmc.FetchMetrics(ctx, existing, pool.Spec.TargetPortNumber)
126131
if err != nil {
127132
errCh <- fmt.Errorf("failed to parse metrics from %s: %v", existing.NamespacedName, err)

pkg/epp/backend/vllm/metrics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func (p *PodMetricsClientImpl) FetchMetrics(
6262

6363
// Currently the metrics endpoint is hard-coded, which works with vLLM.
6464
// TODO(https://github.com/kubernetes-sigs/gateway-api-inference-extension/issues/16): Consume this from InferencePool config.
65-
url := existing.Address + ":" + strconv.Itoa(int(port))
65+
url := existing.Address + ":" + strconv.Itoa(int(port)) + "/metrics"
6666

6767
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
6868
if err != nil {

0 commit comments

Comments
 (0)