Skip to content

Commit 1aba325

Browse files
committed
Add testing results
Signed-off-by: Kunjan Patel <[email protected]>
1 parent ec40820 commit 1aba325

File tree

3 files changed

+2
-21
lines changed

3 files changed

+2
-21
lines changed

examples/dynamic-lora-sidecar/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ The sidecar uses the vLLM server's API to load or unload adapters based on the c
4646
[deployment]: deployment.yaml
4747

4848
## Screenshots & Testing
49-
I tested the sidecar in my cluster with deployment and configmap specified in this repo. Here are the screen grabs of the logs from the sidecar and vllm server.
49+
I tested the sidecar in my cluster with deployment and configmap specified in this repo. Here are the screen grabs of the logs from the sidecar and vllm server. I used the specified configmap, verified that the adapters were loaded by querying `v1/models` and looking at vllm logs. I changed the configmap and validated the same on vllm server. Note: There is slight lag between updates.
5050
![lora-adapter-syncer](screenshots/lora-syncer-sidecar.png)
5151
![config map change](screenshots/configmap-change.png)
5252
![vllm-logs](screenshots/vllm-logs.png)

examples/dynamic-lora-sidecar/sidecar/configmap.yaml

-20
This file was deleted.

examples/dynamic-lora-sidecar/sidecar/sidecar.py

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import yaml
33
import time
44
from watchfiles import awatch
5+
import ipaddress
56
from dataclasses import dataclass
67
import asyncio
78
import logging

0 commit comments

Comments
 (0)