Skip to content

Commit 18f01cc

Browse files
committed
Removed the redundant pool name flag
1 parent 3d3b39a commit 18f01cc

File tree

7 files changed

+9
-15
lines changed

7 files changed

+9
-15
lines changed
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
InferencePool {{ .Values.inferencePool.name }} deployed.
1+
InferencePool {{ .Release.Name }} deployed.

config/charts/inferencepool/templates/_helpers.tpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
1212
Inference extension name
1313
*/}}
1414
{{- define "gateway-api-inference-extension.name" -}}
15-
{{- $base := .Values.inferencePool.name | default "default-pool" | lower | trim | trunc 40 -}}
15+
{{- $base := .Release.Name | default "default-pool" | lower | trim | trunc 40 -}}
1616
{{ $base }}-epp
1717
{{- end -}}
1818

config/charts/inferencepool/templates/_validations.tpl

-5
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@
22
common validations
33
*/}}
44
{{- define "gateway-api-inference-extension.validations.inferencepool.common" -}}
5-
{{- if not $.Values.inferencePool.name }}
6-
{{- fail "missing .Values.inferencePool.name" }}
7-
{{- end }}
8-
9-
105
{{- if or (empty $.Values.inferencePool.modelServers) (not $.Values.inferencePool.modelServers.matchLabels) }}
116
{{- fail ".Values.inferencePool.modelServers.matchLabels is required" }}
127
{{- end }}

config/charts/inferencepool/templates/epp-deployment.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ spec:
2222
imagePullPolicy: {{ .Values.inferenceExtension.image.pullPolicy | default "Always" }}
2323
args:
2424
- -poolName
25-
- {{ .Values.inferencePool.name }}
25+
- {{ .Release.Name }}
2626
- -poolNamespace
2727
- {{ .Release.Namespace }}
2828
- -v

config/charts/inferencepool/templates/gke.yaml

+5-5
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
kind: HealthCheckPolicy
44
apiVersion: networking.gke.io/v1
55
metadata:
6-
name: {{ .Values.inferencePool.name }}
6+
name: {{ .Release.Name }}
77
namespace: {{ .Release.Namespace }}
88
labels:
99
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}
1010
spec:
1111
targetRef:
1212
group: "inference.networking.x-k8s.io"
1313
kind: InferencePool
14-
name: {{ .Values.inferencePool.name }}
14+
name: {{ .Release.Name }}
1515
default:
1616
config:
1717
type: HTTP
@@ -22,22 +22,22 @@ spec:
2222
apiVersion: networking.gke.io/v1
2323
kind: GCPBackendPolicy
2424
metadata:
25-
name: {{ .Values.inferencePool.name }}
25+
name: {{ .Release.Name }}
2626
namespace: {{ .Release.Namespace }}
2727
labels:
2828
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}
2929
spec:
3030
targetRef:
3131
group: "inference.networking.x-k8s.io"
3232
kind: InferencePool
33-
name: {{ .Values.inferencePool.name }}
33+
name: {{ .Release.Name }}
3434
default:
3535
timeoutSec: 300 # 5-minute timeout (adjust as needed)
3636
---
3737
apiVersion: monitoring.googleapis.com/v1
3838
kind: ClusterPodMonitoring
3939
metadata:
40-
name: {{ .Release.Namespace }}-{{ .Values.inferencePool.name }}
40+
name: {{ .Release.Namespace }}-{{ .Release.Name }}
4141
labels:
4242
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}
4343
spec:

config/charts/inferencepool/templates/inferencepool.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
apiVersion: inference.networking.x-k8s.io/v1alpha2
33
kind: InferencePool
44
metadata:
5-
name: {{ .Values.inferencePool.name }}
5+
name: {{ .Release.Name }}
66
namespace: {{ .Release.Namespace }}
77
labels:
88
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}

config/charts/inferencepool/values.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ inferenceExtension:
88
extProcPort: 9002
99

1010
inferencePool:
11-
# name: pool-1 # REQUIRED
1211
targetPortNumber: 8000
1312
# modelServers: # REQUIRED
1413
# matchLabels:

0 commit comments

Comments
 (0)