Merge pull request #75 from nojnhuh/webhook

Add validating admission webhook to Helm chart

Author: k8s-ci-robot

Diff for: README.md

@@ -71,6 +71,21 @@ kube-system          kube-scheduler-dra-example-driver-cluster-control-plane
 local-path-storage   local-path-provisioner-7dbf974f64-9jmc7                            1/1     Running   0          1m
 ```
 
+The validating admission webhook is disabled by default. To enable it, install cert-manager and its CRDs, then
+set the `webhook.enabled=true` value when the dra-example-driver chart is installed.
+```bash
+helm install \
+  --repo https://charts.jetstack.io \
+  --version v1.16.3 \
+  --create-namespace \
+  --namespace cert-manager \
+  --wait \
+  --set crds.enabled=true \
+  cert-manager \
+  cert-manager
+```
+More options for installing cert-manager can be found in [their docs](https://cert-manager.io/docs/installation/)
+
 And then install the example resource driver via `helm`.
 ```bash
 helm upgrade -i \
@@ -83,8 +98,9 @@ helm upgrade -i \
 Double check the driver components have come up successfully:
 ```console
 $ kubectl get pod -n dra-example-driver
-NAME                                             READY   STATUS    RESTARTS   AGE
-dra-example-driver-kubeletplugin-qwmbl           1/1     Running   0          1m
+NAME                                                  READY   STATUS    RESTARTS   AGE
+dra-example-driver-kubeletplugin-qwmbl                1/1     Running   0          1m
+dra-example-driver-webhook-7d465fbd5b-n2wxt           1/1     Running   0          1m
 ```
 
 And show the initial state of available GPU devices on the worker node:

Diff for: cmd/dra-example-kubeletplugin/cdi.go

@@ -20,13 +20,15 @@ import (
 	"fmt"
 	"os"
 
+	"sigs.k8s.io/dra-example-driver/pkg/consts"
+
 	cdiapi "tags.cncf.io/container-device-interface/pkg/cdi"
 	cdiparser "tags.cncf.io/container-device-interface/pkg/parser"
 	cdispec "tags.cncf.io/container-device-interface/specs-go"
 )
 
 const (
-	cdiVendor = "k8s." + DriverName
+	cdiVendor = "k8s." + consts.DriverName
 	cdiClass  = "gpu"
 	cdiKind   = cdiVendor + "/" + cdiClass
 
@@ -60,7 +62,7 @@ func (cdi *CDIHandler) CreateCommonSpecFile() error {
 				ContainerEdits: cdispec.ContainerEdits{
 					Env: []string{
 						fmt.Sprintf("KUBERNETES_NODE_NAME=%s", os.Getenv("NODE_NAME")),
-						fmt.Sprintf("DRA_RESOURCE_DRIVER_NAME=%s", DriverName),
+						fmt.Sprintf("DRA_RESOURCE_DRIVER_NAME=%s", consts.DriverName),
 					},
 				},
 			},

Diff for: cmd/dra-example-kubeletplugin/driver.go

@@ -26,6 +26,8 @@ import (
 	"k8s.io/klog/v2"
 
 	drapbv1 "k8s.io/kubelet/pkg/apis/dra/v1beta1"
+
+	"sigs.k8s.io/dra-example-driver/pkg/consts"
 )
 
 var _ drapbv1.DRAPluginServer = &driver{}
@@ -52,7 +54,7 @@ func NewDriver(ctx context.Context, config *Config) (*driver, error) {
 		[]any{driver},
 		kubeletplugin.KubeClient(config.coreclient),
 		kubeletplugin.NodeName(config.flags.nodeName),
-		kubeletplugin.DriverName(DriverName),
+		kubeletplugin.DriverName(consts.DriverName),
 		kubeletplugin.RegistrarSocketPath(PluginRegistrationPath),
 		kubeletplugin.PluginSocketPath(DriverPluginSocketPath),
 		kubeletplugin.KubeletPluginSocketPath(DriverPluginSocketPath))

Diff for: cmd/dra-example-kubeletplugin/main.go

@@ -28,14 +28,13 @@ import (
 	coreclientset "k8s.io/client-go/kubernetes"
 	"k8s.io/klog/v2"
 
+	"sigs.k8s.io/dra-example-driver/pkg/consts"
 	"sigs.k8s.io/dra-example-driver/pkg/flags"
 )
 
 const (
-	DriverName = "gpu.example.com"
-
-	PluginRegistrationPath     = "/var/lib/kubelet/plugins_registry/" + DriverName + ".sock"
-	DriverPluginPath           = "/var/lib/kubelet/plugins/" + DriverName
+	PluginRegistrationPath     = "/var/lib/kubelet/plugins_registry/" + consts.DriverName + ".sock"
+	DriverPluginPath           = "/var/lib/kubelet/plugins/" + consts.DriverName
 	DriverPluginSocketPath     = DriverPluginPath + "/plugin.sock"
 	DriverPluginCheckpointFile = "checkpoint.json"
 )

Diff for: cmd/dra-example-kubeletplugin/state.go

@@ -27,6 +27,7 @@ import (
 	"k8s.io/kubernetes/pkg/kubelet/checkpointmanager"
 
 	configapi "sigs.k8s.io/dra-example-driver/api/example.com/resource/gpu/v1alpha1"
+	"sigs.k8s.io/dra-example-driver/pkg/consts"
 
 	cdiapi "tags.cncf.io/container-device-interface/pkg/cdi"
 	cdispec "tags.cncf.io/container-device-interface/specs-go"
@@ -180,7 +181,7 @@ func (s *DeviceState) prepareDevices(claim *resourceapi.ResourceClaim) (Prepared
 	// Retrieve the full set of device configs for the driver.
 	configs, err := GetOpaqueDeviceConfigs(
 		configapi.Decoder,
-		DriverName,
+		consts.DriverName,
 		claim.Status.Allocation.Devices.Config,
 	)
 	if err != nil {