Merge pull request #1554 from saschagrunert/cli-default

Remove CLI default values

Author: k8s-ci-robot

Diff for: cmd/crictl/config.go

@@ -46,15 +46,15 @@ CRICTL OPTIONS:
 	Flags: []cli.Flag{
 		&cli.StringFlag{
 			Name:  "get",
-			Usage: "show the option value",
+			Usage: "Show the option value",
 		},
 		&cli.StringSliceFlag{
 			Name:  "set",
-			Usage: "set option (can specify multiple or separate values with commas: opt1=val1,opt2=val2)",
+			Usage: "Set option (can specify multiple or separate values with commas: opt1=val1,opt2=val2)",
 		},
 		&cli.BoolFlag{
 			Name:  "list",
-			Usage: "show all option value",
+			Usage: "Show all option value",
 		},
 	},
 	Action: func(c *cli.Context) error {

Diff for: cmd/crictl/container.go

@@ -102,17 +102,14 @@ var createPullFlags = []cli.Flag{
 	},
 	&cli.StringFlag{
 		Name:  "creds",
-		Value: "",
 		Usage: "Use `USERNAME[:PASSWORD]` for accessing the registry",
 	},
 	&cli.StringFlag{
 		Name:  "auth",
-		Value: "",
 		Usage: "Use `AUTH_STRING` for accessing the registry. AUTH_STRING is a base64 encoded 'USERNAME[:PASSWORD]'",
 	},
 	&cli.StringFlag{
 		Name:  "username",
-		Value: "",
 		Usage: "Use `USERNAME` for accessing the registry. The password will be requested on the command line",
 	},
 	&cli.DurationFlag{
@@ -139,17 +136,14 @@ var runPullFlags = []cli.Flag{
 	},
 	&cli.StringFlag{
 		Name:  "creds",
-		Value: "",
 		Usage: "Use `USERNAME[:PASSWORD]` for accessing the registry",
 	},
 	&cli.StringFlag{
 		Name:  "auth",
-		Value: "",
 		Usage: "Use `AUTH_STRING` for accessing the registry. AUTH_STRING is a base64 encoded 'USERNAME[:PASSWORD]'",
 	},
 	&cli.StringFlag{
 		Name:  "username",
-		Value: "",
 		Usage: "Use `USERNAME` for accessing the registry. password will be requested",
 	},
 	&cli.StringFlag{
@@ -544,29 +538,24 @@ var listContainersCommand = &cli.Command{
 		},
 		&cli.StringFlag{
 			Name:  "id",
-			Value: "",
 			Usage: "Filter by container id",
 		},
 		&cli.StringFlag{
 			Name:  "name",
-			Value: "",
-			Usage: "filter by container name regular expression pattern",
+			Usage: "Filter by container name regular expression pattern",
 		},
 		&cli.StringFlag{
 			Name:    "pod",
 			Aliases: []string{"p"},
-			Value:   "",
 			Usage:   "Filter by pod id",
 		},
 		&cli.StringFlag{
 			Name:  "image",
-			Value: "",
 			Usage: "Filter by container image",
 		},
 		&cli.StringFlag{
 			Name:    "state",
 			Aliases: []string{"s"},
-			Value:   "",
 			Usage:   "Filter by container state",
 		},
 		&cli.StringSliceFlag{

Diff for: cmd/crictl/container_stats.go

@@ -61,13 +61,11 @@ var statsCommand = &cli.Command{
 		},
 		&cli.StringFlag{
 			Name:  "id",
-			Value: "",
 			Usage: "Filter by container id",
 		},
 		&cli.StringFlag{
 			Name:    "pod",
 			Aliases: []string{"p"},
-			Value:   "",
 			Usage:   "Filter by pod id",
 		},
 		&cli.StringSliceFlag{

Diff for: cmd/crictl/exec.go

@@ -58,7 +58,6 @@ var runtimeExecCommand = &cli.Command{
 		},
 		&cli.Int64Flag{
 			Name:  "timeout",
-			Value: 0,
 			Usage: "Timeout in seconds",
 		},
 		&cli.BoolFlag{

Diff for: cmd/crictl/image.go

@@ -57,25 +57,21 @@ var pullImageCommand = &cli.Command{
 	Flags: []cli.Flag{
 		&cli.StringFlag{
 			Name:    "creds",
-			Value:   "",
 			Usage:   "Use `USERNAME[:PASSWORD]` for accessing the registry",
 			EnvVars: []string{"CRICTL_CREDS"},
 		},
 		&cli.StringFlag{
 			Name:    "auth",
-			Value:   "",
 			Usage:   "Use `AUTH_STRING` for accessing the registry. AUTH_STRING is a base64 encoded 'USERNAME[:PASSWORD]'",
 			EnvVars: []string{"CRICTL_AUTH"},
 		},
 		&cli.StringFlag{
 			Name:    "username",
 			Aliases: []string{"u"},
-			Value:   "",
 			Usage:   "Use `USERNAME` for accessing the registry. The password will be requested on the command line",
 		},
 		&cli.StringFlag{
 			Name:      "pod-config",
-			Value:     "",
 			Usage:     "Use `pod-config.[json|yaml]` to override the pull c",
 			TakesFile: true,
 		},

Diff for: cmd/crictl/logs.go

@@ -68,7 +68,6 @@ var logsCommand = &cli.Command{
 		},
 		&cli.StringFlag{
 			Name:  "since",
-			Value: "",
 			Usage: "Show logs since timestamp (e.g. 2013-01-02T13:23:37) or relative (e.g. 42m for 42 minutes)",
 		},
 		&cli.BoolFlag{

Diff for: cmd/crictl/pod_stats.go

@@ -55,7 +55,6 @@ var podStatsCommand = &cli.Command{
 	Flags: []cli.Flag{
 		&cli.StringFlag{
 			Name:  "id",
-			Value: "",
 			Usage: "Filter by pod id",
 		},
 		&cli.StringSliceFlag{

Diff for: cmd/crictl/sandbox.go

@@ -67,7 +67,6 @@ var runPodCommand = &cli.Command{
 		&cli.DurationFlag{
 			Name:    "cancel-timeout",
 			Aliases: []string{"T"},
-			Value:   0,
 			Usage:   "Seconds to wait for a run pod sandbox request to complete before cancelling the request",
 		},
 	},
@@ -250,23 +249,19 @@ var listPodCommand = &cli.Command{
 	Flags: []cli.Flag{
 		&cli.StringFlag{
 			Name:  "id",
-			Value: "",
 			Usage: "filter by pod id",
 		},
 		&cli.StringFlag{
 			Name:  "name",
-			Value: "",
 			Usage: "filter by pod name regular expression pattern",
 		},
 		&cli.StringFlag{
 			Name:  "namespace",
-			Value: "",
 			Usage: "filter by pod namespace regular expression pattern",
 		},
 		&cli.StringFlag{
 			Name:    "state",
 			Aliases: []string{"s"},
-			Value:   "",
 			Usage:   "filter by pod state",
 		},
 		&cli.StringSliceFlag{