Merge pull request #1150 from everettraven/feature/optional-oldself-xvalidation

✨ markers: add support for optionalOldSelf in XValidation marker

Author: k8s-ci-robot

Diff for: pkg/crd/markers/validation.go

@@ -335,6 +335,7 @@ type XValidation struct {
 	MessageExpression string `marker:"messageExpression,optional"`
 	Reason            string `marker:"reason,optional"`
 	FieldPath         string `marker:"fieldPath,optional"`
+	OptionalOldSelf   *bool  `marker:"optionalOldSelf,optional"`
 }
 
 func (m Maximum) ApplyToSchema(schema *apiext.JSONSchemaProps) error {
@@ -603,6 +604,7 @@ func (m XValidation) ApplyToSchema(schema *apiext.JSONSchemaProps) error {
 		MessageExpression: m.MessageExpression,
 		Reason:            reason,
 		FieldPath:         m.FieldPath,
+		OptionalOldSelf:   m.OptionalOldSelf,
 	})
 	return nil
 }

Diff for: pkg/crd/markers/zz_generated.markerhelp.go

@@ -381,6 +381,10 @@ type CronJobSpec struct {
 
 	// This tests that embedded struct, which is an alias type, is handled correctly.
 	InlineAlias `json:",inline"`
+
+	// Test that we can add a field that can only be set to a non-default value on updates using XValidation OptionalOldSelf.
+	// +kubebuilder:validation:XValidation:rule="oldSelf.hasValue() || self == 0",message="must be set to 0 on creation. can be set to any value on an update.",optionalOldSelf=true
+	OnlyAllowSettingOnUpdate int32 `json:"onlyAllowSettingOnUpdate,omitempty"`
 }
 
 type InlineAlias = EmbeddedStruct

Diff for: pkg/crd/testdata/cronjob_types.go

@@ -8967,6 +8967,16 @@ spec:
                   This flag is like suspend, but for when you really mean it.
                   It helps test the +kubebuilder:validation:Type marker.
                 type: string
+              onlyAllowSettingOnUpdate:
+                description: Test that we can add a field that can only be set to
+                  a non-default value on updates using XValidation OptionalOldSelf.
+                format: int32
+                type: integer
+                x-kubernetes-validations:
+                - message: must be set to 0 on creation. can be set to any value on
+                    an update.
+                  optionalOldSelf: true
+                  rule: oldSelf.hasValue() || self == 0
               patternObject:
                 description: This tests that pattern validator is properly applied.
                 pattern: ^$|^((https):\/\/?)[^\s()<>]+(?:\([\w\d]+\)|([^[:punct:]\s]|\/?))$